-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#146]: Implement logic to render selected layers in Editor #154
[#146]: Implement logic to render selected layers in Editor #154
Conversation
✅ UBUNTU COMPILE RESULT - SUCCESS! ✅ |
✅ WINDOWS COMPILE RESULT - SUCCESS! ✅ |
⚡ Static analysis result ⚡ 🔴 cppcheck found 27 issues! Click here to see details.Lines 121 to 126 in 1b68d11
!Line: 121 - style: inconclusive: Technically the member function 'looper::Editor::DrawGrid' can be const. [functionConst]
!Line: 729 - note: Technically the member function 'looper::Editor::DrawGrid' can be const.
!Line: 121 - note: Technically the member function 'looper::Editor::DrawGrid' can be const. Lines 220 to 225 in 1b68d11
!Line: 220 - style: inconclusive: Technically the member function 'looper::Editor::SetMouseOnObject' can be const. [functionConst]
!Line: 249 - note: Technically the member function 'looper::Editor::SetMouseOnObject' can be const.
!Line: 220 - note: Technically the member function 'looper::Editor::SetMouseOnObject' can be const. Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Looper/engine/input/input_manager.cpp Lines 28 to 33 in 1b68d11
!Line: 28 - style: Parameter 'window' can be declared as pointer to const. However it seems that 'InternalKeyCallback' is a callback function, if 'window' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
!Line: 96 - note: You might need to cast the function pointer here
!Line: 28 - note: Parameter 'window' can be declared as pointer to const Looper/engine/input/input_manager.cpp Lines 40 to 45 in 1b68d11
!Line: 40 - style: Parameter 'window' can be declared as pointer to const. However it seems that 'InternalCharCallback' is a callback function, if 'window' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
!Line: 97 - note: You might need to cast the function pointer here
!Line: 40 - note: Parameter 'window' can be declared as pointer to const Looper/engine/input/input_manager.cpp Lines 50 to 55 in 1b68d11
!Line: 50 - style: Parameter 'window' can be declared as pointer to const. However it seems that 'InternalMouseButtonCallback' is a callback function, if 'window' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
!Line: 98 - note: You might need to cast the function pointer here
!Line: 50 - note: Parameter 'window' can be declared as pointer to const Looper/engine/input/input_manager.cpp Lines 61 to 66 in 1b68d11
!Line: 61 - style: Parameter 'window' can be declared as pointer to const. However it seems that 'InternalCursorPositionCallback' is a callback function, if 'window' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
!Line: 99 - note: You might need to cast the function pointer here
!Line: 61 - note: Parameter 'window' can be declared as pointer to const Looper/engine/input/input_manager.cpp Lines 72 to 77 in 1b68d11
!Line: 72 - style: Parameter 'window' can be declared as pointer to const. However it seems that 'InternalMouseScrollCallback' is a callback function, if 'window' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
!Line: 100 - note: You might need to cast the function pointer here
!Line: 72 - note: Parameter 'window' can be declared as pointer to const Looper/engine/input/input_manager.cpp Lines 82 to 87 in 1b68d11
!Line: 82 - style: Parameter 'window' can be declared as pointer to const. However it seems that 'InternalWindowFocusCallback' is a callback function, if 'window' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
!Line: 101 - note: You might need to cast the function pointer here
!Line: 82 - note: Parameter 'window' can be declared as pointer to const Looper/engine/renderer/buffer.cpp Lines 57 to 62 in 1b68d11
!Line: 57 - style: Parameter 'data' can be declared as pointer to const [constParameterPointer] Looper/engine/renderer/buffer.cpp Lines 74 to 79 in 1b68d11
!Line: 74 - style: Parameter 'data' can be declared as pointer to const [constParameterPointer] Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Looper/engine/renderer/texture.hpp Lines 78 to 83 in 1b68d11
!Line: 78 - style: inconclusive: Technically the member function 'looper::renderer::Texture::TransitionImageLayout' can be const. [functionConst]
!Line: 434 - note: Technically the member function 'looper::renderer::Texture::TransitionImageLayout' can be const.
!Line: 78 - note: Technically the member function 'looper::renderer::Texture::TransitionImageLayout' can be const. Looper/engine/renderer/texture.hpp Lines 81 to 86 in 1b68d11
!Line: 81 - style: inconclusive: Technically the member function 'looper::renderer::Texture::CopyBufferToImage' can be const. [functionConst]
!Line: 378 - note: Technically the member function 'looper::renderer::Texture::CopyBufferToImage' can be const.
!Line: 81 - note: Technically the member function 'looper::renderer::Texture::CopyBufferToImage' can be const. Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class Lines 61 to 66 in 1b68d11
!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class 🔴 clang-tidy found 5 issues! Click here to see details.Looper/engine/renderer/shader.cpp Lines 14 to 19 in 1b68d11
!Line: 14 - error: function 'CreateShaderModule' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace,-warnings-as-errors] Looper/engine/core/work_queue.cpp Lines 11 to 16 in 1b68d11
!Line: 11 - error: use emplace_back instead of push_back [hicpp-use-emplace,modernize-use-emplace,-warnings-as-errors] Lines 6 to 11 in 1b68d11
!Line: 6 - error: function 'TypeToString' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace,-warnings-as-errors] Looper/engine/game/animatable.cpp Lines 90 to 95 in 1b68d11
!Line: 90 - error: avoid do-while loops [cppcoreguidelines-avoid-do-while,-warnings-as-errors] Looper/engine/renderer/renderer.cpp Lines 746 to 751 in 1b68d11
!Line: 746 - error: performing an implicit widening conversion to type 'size_type' (aka 'unsigned long') of a multiplication performed in type 'uint32_t' (aka 'unsigned int') [bugprone-implicit-widening-of-multiplication-result,-warnings-as-errors]
!Line: 746 - note: make conversion explicit to silence this warning
!Line: 746 - note: perform multiplication in a wider type |
Fixes #146