Use std::expected instead of std::error_code reference #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an equivalent to std::expected
Updated `receive_raw_message` and `send_raw_message` methods in the `connection` class to return `async_operation` with `std::error_code`. This change eliminates the need to pass error codes by reference. Implemented error handling using `co_return` with `std::make_error_code`. Added a check in `send_raw_message` to ensure message size matches bytes sent. Included `error.h` in `connection.cpp`.
Replaced individual `using` declarations for `tl::unexpected`, `tl::expected`, `tl::make_unexpected`, and `tl::swap` with a single `using namespace tl;` statement within the `std` namespace. This change reduces redundancy and makes the code cleaner and easier to maintain.
Jacquwes
had a problem deploying
to
github-pages
GitHub Actions
Failure
Jacquwes
deleted the
10-use-stdexpected-as-return-type-instead-of-passing-error_code-reference
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Classification
API change to modernize and simplify error handling.
PR Summary
Refactored codebase to use
std::expectedandasync_operationwithstd::error_codefor improved error handling.client_connection.handclient_connection.cpp: Switched toasync_operationwithstd::error_code.server.handserver.cpp: Adoptedstd::expectedfor error handling.coroutine.h: Replacedasync_taskwithasync_operationusingstd::expected.client_example.cppandserver_example.cpp: Updatedmainfunction for new error handling.CMakeLists.txt: Included newexpected.hheader file.closes: #10