Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement routing #31

Merged
merged 69 commits into from
Nov 9, 2024
Merged

Implement routing #31

merged 69 commits into from
Nov 9, 2024

Conversation

Jacquwes
Copy link
Owner

@Jacquwes Jacquwes commented Nov 9, 2024

PR Classification

New feature and code enhancement.

PR Summary

This pull request introduces new routing capabilities and enhances the server's functionality, along with switching the testing framework to Doctest.

  • CMakeLists.txt: Enabled export of compile commands, added new source files, and switched to Doctest for testing.
  • server_example.cpp: Added routes to handle various HTTP requests and serve static files.
  • server.h and server_connection.h: Added methods for managing routes and handling HTTP requests.
  • Added route_node.h, route_path.h, and route_tree.h to define classes for managing HTTP routes.
  • client_connection.cpp: Simplified return statement.

@Jacquwes
Create basic route type
6baf848
@Jacquwes
Create a function to add a route to the server
f6b8275
@Jacquwes
Store server reference in server connections
c67de15
@Jacquwes
Create get route by path function
c4dc79d
@Jacquwes
Make connection call the handler associated with the request uri if f…
655c698 
…ound
@Jacquwes
Fix an issue where std::expected was used incorrectly in coroutines
c8c5f00
@Jacquwes
Close the connection after sending the response
c3ab06a
@Jacquwes
Add information to the not found response so clients can detect it
9929348
@Jacquwes
Check for errors while sending the response
1980f1a
@Jacquwes
Improve example by demonstrating add_route
abe3b6f
@Jacquwes
Rename server_route to route
00b85b6
@Jacquwes
Create route_base type inherited by route
cbed0be
@Jacquwes
Add header guards
c99d7b5
@Jacquwes
Create customizable route matching function for future route types
0eeb48c
@Jacquwes
Use route_base instead of route
3056c70
@Jacquwes
Create static route to serve files and directories without overhead.
9538687 
closes: #20
@Jacquwes
Simplify execute function
d49502c
@Jacquwes
Add method not allowed http status code
942770e
@Jacquwes
Move the path responsibility to route_base
f3f950d
@Jacquwes
Move request handling to separate function
a32f9cc
@Jacquwes
Add string for method not allowed http status code
ef03c59
@Jacquwes
Add HTTP methods support to route_base
65c42b4
@Jacquwes
Allow instanciation of routes with methods
d81fcbd
@Jacquwes
Update server example to add methods
1cd2496
@Jacquwes
Modify server logic allowing for different routes using the same path…
17e3ed6 
… but different methods
@Jacquwes
Merge pull request #21 from Jacquwes/19-implement-request-methods-for…
fa6fb03 
…-routes
@Jacquwes
Create route_path class for compilation time route path check
8548771
@Jacquwes
Use route_path type for paths
b5de39a
@Jacquwes
Merge pull request #27 from Jacquwes/22-compile-time-route-path-valid…
f42b804 
…ation
@Jacquwes
Add comments to example
3f29563
@Jacquwes
Change GTest code for doctest code
c1c387e
@Jacquwes
Remove unused file
604a51a
@Jacquwes
Merge pull request #29 from Jacquwes/use-doctest-instead-of-gtest
34fb347
@Jacquwes
Add tests for routes
e55e276
@Jacquwes
Add missing HTTP method strings
aaf0c86
@Jacquwes
Delete unused file
ecbd92b
@Jacquwes
Add getters
2dc85d5
@Jacquwes
Add error when trying to add two path parameters children to one node
307b736
@Jacquwes
Improve child matching logic
3668e92
@Jacquwes
Include for std::min
29b195c
@Jacquwes
Constructor now adds all children when trying to create a multiple se…
d06fa57 
…gment node
@Jacquwes
Make get_deepest_node also return the depth of the found node
4fca783
@Jacquwes
Ignore segment separators (/)
5e6fc73
@Jacquwes
Use depth to add children to the correct node
826dba8
@Jacquwes
Update server example to match new architecture
e966ca5
@Jacquwes
Merge branch '28-routes-should-be-stored-in-an-efficient-data-structu…
0537aa9 
…re-radix-tree' of https://github.com/Jacquwes/pine-http into 28-routes-should-be-stored-in-an-efficient-data-structure-radix-tree
@Jacquwes
Merge pull request #30 from Jacquwes/28-routes-should-be-stored-in-an…
850de0e 
…-efficient-data-structure-radix-tree
@Jacquwes
Improve coherence of body content
672b810
@Jacquwes
Add error codes for path params
4a3947e
@Jacquwes
Fix documentation
311f388
@Jacquwes
Implement function to get path params
45cc088
@Jacquwes
Implement function to parse path params in request
c21a857
@Jacquwes
Add path params to request in handler
f679eb6
@Jacquwes
Update example to showcase use of path params
3c14569
@Jacquwes
Simplify unknown route handling
cf4408c
@Jacquwes
Fix logic which was matching incorrect routes (/mike/wrong was ok for…
a499123 
… /:name route)
@Jacquwes
Fix index increment logic in route_tree.cpp
4e3ba9b
@Jacquwes Jacquwes linked an issue Nov 9, 2024 that may be closed by this pull request
Implement paths #14
Open
8 tasks
@Jacquwes Jacquwes merged commit 7cfb742 into master Nov 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement paths
1 participant
@Jacquwes