pyproject.toml improvements #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esbuild after 0.16.0 was moved under a scoped name
If for some reason workspace is empty, root_toml['workspace'] is {},
which was raising a KeyError.
This was triggered by librespot:
https://github.com/librespot-org/librespot/blob/dev/Cargo.toml#L13
and non-registry sources. Also remove code with repeating logic.
Also recommend using `--runtime`.
This option takes a comma-separated list of package names. It adds the `--ignore-installed` option to the pip command for these packages. This is necessary for packages that are installed in the Sdk but then not part of the runtime (e.g. [lxml][1]). [1]: https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/380
including versions of - SDK - Node.js - Electron It's impossible to upgrade SDKs for `build.electron.webpack.ElectronWebpackQuickStart` without replacing the `package.json` due to `error:0308010C:digital envelope routines::unsupported`. So I keep it as is.
…tpak#346) * dotnet: Add flags for dotnet and freedesktop sdk Adds the --freedesktop, -f, --dotnet, -d arguments to the script. Allows you to specify the dotnet version and which freedesktop sdk branch to use. * dotnet: update docs for arguments, usage. Adds section detailing arguments, updating some of the README to clarify usage. * Use f-strings instead of str.format. * Remove choices, add variables to ease bumping versions. * docs: Moved arguments section to bottom of README.
* enable separate locales for electron apps * include the script in the base * no need to pass the `/locales` subdir passing the `/locales` subdir is redundant and the base will add it for you
Cargo with `inherit-workspace` feature requires workspace packages Cargo.toml's to be resolved when using vendored sources, because the workspace manifest won't be available when building them.
If pip fails to download, the generated sources file is empty and, arguably, useless. Instead of silently generating an empty file, the error is propagated now. The root cause appears to be a bug in pip. flatpak#265
Added: error thorwn if both --requirements-file and --pyproject-file are present Added: readme entry for --pyproject-file Fixed: readme entry for --requirements-file now warns about mutual exclusivity with --pyproject-file
ENDrain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there! I'm trying to help with your PR at flatpak-builder-tools: flatpak#332. If I get this right, you need to merge my PR into your PR, and then your PR on origin will update aotumatically. Hope you're still interested in this!
pip: Add support for pyproject.toml
Added: error thorwn if both --requirements-file and --pyproject-file are present
Added: readme entry for --pyproject-file
Fixed: readme entry for --requirements-file now warns about mutual exclusivity with --pyproject-file