HLSLCrossCompiler: Fix NULL pointer dereference on dcl_uav_structured #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following commit introduced a NULL pointer dereference that can
crash the HLSL cross compiler if it processes a shader that includes an
RWStructuredBuffer that has had its reflection information stripped:
commit 0659b1f
Author: James Jones <[email protected]>
Date: Fri Jan 17 12:21:23 2014 +0000
Fixes image_load_store and shader_storage_buffer_object features
This restores the if block to make the processing conditional on the
reflection information being found. This by itself may not be
immediately useful for the standalone HLSLCrossCompiler project that
does not expect to process stripped shaders, but it is necessary for
projects that use HLSLCrossCompiler as a library to decode shaders, such
as in 3DMigoto.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commit introduced a NULL pointer dereference that can
crash the HLSL cross compiler if it processes a shader that includes an
RWStructuredBuffer that has had its reflection information stripped:
This restores the if block to make the processing conditional on the
reflection information being found. This by itself may not be
immediately useful for the standalone HLSLCrossCompiler project that
does not expect to process stripped shaders, but it is necessary for
projects that use HLSLCrossCompiler as a library to decode shaders, such
as in 3DMigoto.