Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress not ready to merge - but opening this PR for discussion. This is my attempt to make a "unified" interface for converting physical NFW parameters to AutoLens's parameterization (kappa_s, scale_radius), using Colossus to do all the conversions.
The advantages of this approach are:
Mvir
,M200m
,M200c
would all be handled correctlyI can think of one disadvantage:
sigma8
andns
defined, which we don't usually care about. This is not a big problem since I am quite sure these parameters are not used in the NFW conversions, but making sure Colossus is used cleanly and consistently might take a little thought.