Improve append #46
Merged
Improve append #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
reviewed
Oct 24, 2024
rdettai
reviewed
Oct 24, 2024
rdettai
reviewed
Oct 26, 2024
rdettai
reviewed
Oct 29, 2024
| } | ||
|
|
||
| /// Splits the datafiles *n_split* times to decrease the number of datafiles per maniefst. 1 split returns 2 outputs vectors, 2 splits return 4, 3 splits return 8 and so on. | ||
| pub(crate) fn split_datafiles( |
There was a problem hiding this comment.
Ideally, this should be unit tested as well.
There was a problem hiding this comment.
Creating mocked data for a unit test is quite difficult here. I expanded a datafusion test to cover the manifest splitting case.
There was a problem hiding this comment.
Operation.execute() is too big, which makes it hard to read the change. Could you refactor it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Append Operation in that it selects only a single manifest file to append the new datafiles to. In case the number of datafiles exceeds a certain threshold, the manifest file is split into smaller manifest files.
This should improve insert performance, as well as the overall structure of the manifest_list/manifest tree.