Skip to content

Commit

Permalink
[UE5.4] Updated to newest engine version
Browse files Browse the repository at this point in the history
  • Loading branch information
JanSeliv committed Apr 1, 2024
1 parent 2097963 commit 781dcbe
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 16 deletions.
2 changes: 1 addition & 1 deletion PoolManager.uplugin
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"DocsURL": "",
"MarketplaceURL": "",
"SupportURL": "mailto:[email protected]",
"EngineVersion": "5.3.0",
"EngineVersion": "5.4.0",
"EnabledByDefault": true,
"CanContainContent": false,
"IsBetaVersion": false,
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ Check out our [Release](https://github.com/JanSeliv/PoolManager/releases) page f
Also, explore this [game project repository](https://github.com/JanSeliv/Bomber) to view the Pool Manager in action.

## 📅 Changelog
####
- Updated to **Unreal Engine 5.4**.
#### 2023-11-25
- Updated to **Unreal Engine 5.3**.
- Introduced **Factories** to handle differences in pools by object archetypes (e.g.: uobjects, actors, components, widgets etc.).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include "Factories/PoolFactory_UObject.h"
//---
#include "Data/PoolManagerSettings.h"
#include "Engine/World.h"
//---
#include UE_INLINE_GENERATED_CPP_BY_NAME(PoolFactory_UObject)

Expand Down
6 changes: 2 additions & 4 deletions Source/PoolManager/Private/PoolManagerModule.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Copyright (c) Yevhenii Selivanov.

#include "PoolManagerModule.h"

#define LOCTEXT_NAMESPACE "FPoolManagerModule"
//---
#include "Modules/ModuleManager.h"

void FPoolManagerModule::StartupModule()
{
Expand All @@ -15,6 +15,4 @@ void FPoolManagerModule::ShutdownModule()
// we call this function before unloading the module.
}

#undef LOCTEXT_NAMESPACE

IMPLEMENT_MODULE(FPoolManagerModule, PoolManager)
4 changes: 2 additions & 2 deletions Source/PoolManager/Private/PoolManagerSubsystem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ void UPoolManagerSubsystem::BPTakeFromPool(const UClass* ObjectClass, const FTra
FSpawnRequest Request;
Request.Class = ObjectClass;
Request.Transform = Transform;
Request.Callbacks.OnPostSpawned = [Completed](const FPoolObjectData& ObjectData)
Request.Callbacks.OnPostSpawned = [Completed](const FPoolObjectData& It)
{
Completed.ExecuteIfBound(ObjectData.PoolObject);
Completed.ExecuteIfBound(It.PoolObject);
};
CreateNewObjectInPool(Request);
}
Expand Down
4 changes: 2 additions & 2 deletions Source/PoolManagerEditor/Private/K2Node_TakeFromPool.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ void UK2Node_TakeFromPool::ExpandNode(class FKismetCompilerContext& CompilerCont

// Create Completed delegate parameter
const FName DelegateCompletedParamName(TEXT("Completed"));
UK2Node_CustomEvent* CompletedEventNode = CompilerContext.SpawnIntermediateEventNode<UK2Node_CustomEvent>(this, CallClassPin, SourceGraph);
UK2Node_CustomEvent* CompletedEventNode = CompilerContext.SpawnIntermediateNode<UK2Node_CustomEvent>(this, SourceGraph);
CompletedEventNode->CustomFunctionName = *FString::Printf(TEXT("Completed_%s"), *CompilerContext.GetGuid(this));
CompletedEventNode->AllocateDefaultPins();
{
Expand Down Expand Up @@ -263,7 +263,7 @@ bool UK2Node_TakeFromPool::IsCompatibleWithGraph(const UEdGraph* TargetGraph) co
bool bIsCompatible = false;
// Can only place events in ubergraphs and macros (other code will help prevent macros with latents from ending up in functions), and basicasync task creates an event node:
const EGraphType GraphType = TargetGraph->GetSchema()->GetGraphType(TargetGraph);
if (GraphType == EGraphType::GT_Ubergraph || GraphType == EGraphType::GT_Macro)
if (GraphType == GT_Ubergraph || GraphType == GT_Macro)
{
bIsCompatible = true;
}
Expand Down
8 changes: 3 additions & 5 deletions Source/PoolManagerEditor/Private/PoolManagerEditorModule.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Copyright (c) Yevhenii Selivanov.

#include "PoolManagerEditorModule.h"

#define LOCTEXT_NAMESPACE "FPoolManagerEditorModule"
//---
#include "Modules/ModuleManager.h"

void FPoolManagerEditorModule::StartupModule()
{
Expand All @@ -15,6 +15,4 @@ void FPoolManagerEditorModule::ShutdownModule()
// we call this function before unloading the module.
}

#undef LOCTEXT_NAMESPACE

IMPLEMENT_MODULE(FPoolManagerEditorModule, PoolManagerEditor)
IMPLEMENT_MODULE(FPoolManagerEditorModule, PoolManagerEditor)
2 changes: 0 additions & 2 deletions Source/PoolManagerEditor/Public/PoolManagerEditorModule.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
#pragma once

#include "Modules/ModuleInterface.h"
//---
#include "Modules/ModuleManager.h"

class POOLMANAGEREDITOR_API FPoolManagerEditorModule : public IModuleInterface
{
Expand Down

0 comments on commit 781dcbe

Please sign in to comment.