Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating notebook for more elaborate tutorial 📔 #105

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KristinaUlicna
Copy link
Collaborator

@KristinaUlicna KristinaUlicna commented Nov 3, 2023

PR summary:

Changes to the ctc.ipynb notebook to:

What should the reviewer focus their feedback on?

  • Overall sanity check (motivation behind the plot)
  • Code documentation / annotation quality

@KristinaUlicna KristinaUlicna self-assigned this Nov 3, 2023
@KristinaUlicna KristinaUlicna added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Nov 3, 2023
Copy link
Collaborator

@msschwartz21 msschwartz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice first upgrade! A few initial thoughts

  • Can we clear the error message output from the download cell?
  • The issue that necessitated the tracking_graph_data_loader will be fixed in Refactor existing Matched into separate Matcher which returns Matched #103 so I would like to maybe wait for that PR and then update this notebook accordingly.
  • Can we add back a non-zero frame buffer value in at least one case of the division metrics?

@KristinaUlicna
Copy link
Collaborator Author

Ofc, implementing rn! Thanks for the suggestions @msschwartz21 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
2 participants