Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CTCMatcher using standard test cases #174

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

msschwartz21
Copy link
Collaborator

@msschwartz21 msschwartz21 commented Dec 12, 2024

Branch based on #173

Proposed Change

  • Use example segmentation tests cases for testing the ctc matcher
  • Refactor the matcher to have a stand alone function that does the core matching of two frames (for easier testing)

Types of Changes

What types of changes does your code introduce? Delete those that do not apply.

  • New feature or enhancement
  • Tests and benchmarks

Which topics does your change affect? Delete those that do not apply.

  • Matchers

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the developer/contributing docs.
  • I have added tests that prove that my feature works in various situations or tests the bugfix (if appropriate).
  • I have checked that I maintained or improved code coverage.
  • I have checked the benchmarking action to verify that my changes did not adversely affect performance.
  • I have written docstrings and checked that they render correctly in the Read The Docs build (created after the PR is opened).
  • I have updated the general documentation including Metric descriptions and example notebooks if necessary.

@msschwartz21 msschwartz21 added the tests Test case related issues label Dec 12, 2024
@msschwartz21 msschwartz21 changed the base branch from main to iou-tests December 12, 2024 19:30
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.81%. Comparing base (cb65542) to head (4976e09).
Report is 5 commits behind head on iou-tests.

Additional details and impacted files
@@              Coverage Diff              @@
##           iou-tests     #174      +/-   ##
=============================================
+ Coverage      92.37%   92.81%   +0.43%     
=============================================
  Files             19       19              
  Lines            879      877       -2     
=============================================
+ Hits             812      814       +2     
+ Misses            67       63       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @msschwartz21 ☺️

@msschwartz21 msschwartz21 merged commit 3c72679 into iou-tests Dec 16, 2024
15 checks passed
@msschwartz21 msschwartz21 deleted the ctc-matcher-tests branch December 16, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Test case related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants