Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test division errors using standard test cases #177

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Test division errors using standard test cases #177

merged 2 commits into from
Dec 19, 2024

Conversation

msschwartz21
Copy link
Collaborator

@msschwartz21 msschwartz21 commented Dec 18, 2024

Types of Changes

What types of changes does your code introduce? Delete those that do not apply.

  • Tests and benchmarks

Which topics does your change affect? Delete those that do not apply.

  • Track Errors

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the developer/contributing docs.
  • I have added tests that prove that my feature works in various situations or tests the bugfix (if appropriate).
  • I have checked that I maintained or improved code coverage.
  • I have checked the benchmarking action to verify that my changes did not adversely affect performance.
  • I have written docstrings and checked that they render correctly in the Read The Docs build (created after the PR is opened).
  • I have updated the general documentation including Metric descriptions and example notebooks if necessary.

@msschwartz21 msschwartz21 added the tests Test case related issues label Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (68d63ad) to head (0b6ea61).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   92.81%   93.15%   +0.34%     
==========================================
  Files          19       19              
  Lines         877      877              
==========================================
+ Hits          814      817       +3     
+ Misses         63       60       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cmalinmayor cmalinmayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameterization is getting pretty wild 😆 I think we can come up with something a bit cleaner. We can discuss offline and add the final decision to the conversation.

tests/track_errors/test_divisions.py Outdated Show resolved Hide resolved
tests/track_errors/test_divisions.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@cmalinmayor cmalinmayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙂 🎉

@msschwartz21 msschwartz21 merged commit 2ce238f into main Dec 19, 2024
14 of 15 checks passed
@msschwartz21 msschwartz21 deleted the div-test branch December 19, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Test case related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants