Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CTC NodeFlags and EdgeFlags #179

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Rename CTC NodeFlags and EdgeFlags #179

merged 1 commit into from
Jan 2, 2025

Conversation

msschwartz21
Copy link
Collaborator

@msschwartz21 msschwartz21 commented Dec 19, 2024

Prefixes ctc specific flags with "CTC_". This will allow us to isolate the CTC specific annotations and in the future create our own set of edge and node annotations.

Types of Changes

What types of changes does your code introduce? Delete those that do not apply.

  • Bugfix (non-breaking change which fixes an issue)

Which topics does your change affect? Delete those that do not apply.

  • Track Errors
  • Core functionality (e.g. TrackingGraph, run_metrics, cli, etc.)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the developer/contributing docs.
  • I have added tests that prove that my feature works in various situations or tests the bugfix (if appropriate).
  • I have checked that I maintained or improved code coverage.
  • I have checked the benchmarking action to verify that my changes did not adversely affect performance.
  • I have written docstrings and checked that they render correctly in the Read The Docs build (created after the PR is opened).
  • I have updated the general documentation including Metric descriptions and example notebooks if necessary.

@msschwartz21 msschwartz21 changed the base branch from main to track-errors December 19, 2024 21:54
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (f748876) to head (7ea7fa2).
Report is 6 commits behind head on track-errors.

Additional details and impacted files
@@               Coverage Diff                @@
##           track-errors     #179      +/-   ##
================================================
+ Coverage         92.83%   93.17%   +0.34%     
================================================
  Files                19       19              
  Lines               879      879              
================================================
+ Hits                816      819       +3     
+ Misses               63       60       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msschwartz21 msschwartz21 merged commit dd892f0 into track-errors Jan 2, 2025
15 checks passed
@msschwartz21 msschwartz21 deleted the ctc-flags branch January 2, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant