Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable codecov #69

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

tlambert03
Copy link
Contributor

might as well :)

Copy link
Collaborator

@msschwartz21 msschwartz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we didn't enable this early on because it was too depressing when we were just getting started, but 83% coverage isn't too shabby!

Comment on lines +12 to +14
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure I understand, if we push a new commit on the same branch, this will cancel in progress workflows on the previous commit and then run the workflows on the new commit?

Copy link
Contributor Author

@tlambert03 tlambert03 Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sorry, should have commented on that. that's exactly right. it just saves CI time.
more here: https://docs.github.com/en/actions/using-jobs/using-concurrency#overview

Copy link
Collaborator

@cmalinmayor cmalinmayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Talley!

@cmalinmayor cmalinmayor merged commit d3560d1 into Janelia-Trackathon-2023:main Nov 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants