Fix race condition #117 #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.batchSent() | ||
| resolve() | ||
| }) | ||
| .catch(err => { | ||
| // Revert batch for the logs to be sent on the next iteration | ||
| this.batch.streams = savedBatchStreams |
There was a problem hiding this comment.
Sorry, took a while to look at this, but doesn't this just reintroduce the same race condition but in a new place? You'd need to combine the savedBatchStreams & this.batch.streams in a nonduplicative and a nondestructive manner, like merging sets.
There was a problem hiding this comment.
This sure fixes the problem so that it only happens when the request fails which decreases its frequency quite a bit. I'll draft something based on this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #117