Added BAMO #348
Merged
Added BAMO #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reviewed your submission. Two notes:
|
|
Both changes made. Anything else that looks off? |
|
I noticed that you can still make the plugin 2x smaller if you remove the babel-loader rule from webpack config. Also please make sure to update the plugin file in the ./plugins folder. |
|
@tmudway Any news on how this is going? Just curious since this seems like a cool plugin |
|
Updated with requested changes |
|
Sorry this has been in the queue for so long! |
|
Not blocking, but I would recommend including the link to documentation in a clickable way. To do that, you can use the "website" metadata field and you can additionally provide an about text. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.