Group Exporter #542
Merged
Group Exporter #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JannisX11
reviewed
May 26, 2024
|
I've addressed your feedback, and made changes where necessary. I don't have any further additions, so this PR is ready to go. |
|
I just found one more issue regarding "Export" being a public function. Do you mind if I fix that? |
|
Yeah, you can make the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group Exporter is a plugin that allows designers to export a group from the outliner as a model. Only the cubes inside the group (including sub-groups) will be considered for the exported file. Useful when designing models that are made up of multiple models, or even as a tool to design models in a single project instead of multiple projects (within reasonable context) since you can just export the group, not the whole project.
This plugin is very dependent on the fact
computeCubehas a check right at the startc.export. If this was applied across the board, this plugin could theoretically support more formats.https://github.com/JannisX11/blockbench/blob/42c77fa4737de43686e8925ca0ac54e5d241c5c9/js/io/formats/java_block.js#L29
Example of a use case:
This is a backpack I am designing. It needs to be two separate models for my mod, instead of deleting the elements to only export specific elements, I can just export the group.