Add New Plugin "Meshy" #625
Conversation
|
currently overwrites codec.parse and codec.compile haven't made the switch to events might do that in the future |
plugins/meshy/meshy.js
Outdated
| (function() { | ||
| const pluginInfo = {"name":"Meshy","id":"meshy","version":"1.0.2","repository":"https://github.com/Shadowkitten47/Meshy"}; | ||
|
|
||
| if (!settings["normalized_uvs"]) |
There was a problem hiding this comment.
Settings IDs are very generic right now. These should be namespaced (e.g. meshy_normalized_uvs) to avoid conflicts with other plugins. The same applies to names. When looking through the settings, users will have no idea what "Meta Data" refers to without context.
plugins/meshy/meshy.js
Outdated
| plugin: pluginInfo.id | ||
| }) | ||
| } | ||
| if (!settings["Force Multi-Textures"]) |
plugins/meshy/meshy.js
Outdated
|
|
||
|
|
||
| if (!BarItems['quick_reload']) { | ||
| new Action('quick_reload', { |
There was a problem hiding this comment.
It's recommended to move setting up the plugin into onload. That way actions will be registered as part of the plugin.
plugins/meshy/meshy.js
Outdated
| if (!settings["normalized_uvs"]) | ||
| new Setting("normalized_uvs", { | ||
| name: "Normalize UVs", | ||
| description: "Normalize uvs on export", |
There was a problem hiding this comment.
Suggestion to move these to the export category. They seem pretty lost in the General settings page right now.
| bedrock_old.single_texture = !settings["single_texture"]?.value | ||
|
|
||
| }, | ||
| onunload() { |
There was a problem hiding this comment.
Settings and actions are not cleaned up when uninstalling. You can do this here via setting_xy.delete(); etc.
plugins/meshy/src/main.js
Outdated
| @@ -0,0 +1,83 @@ | |||
| const pluginInfo = { | |||
There was a problem hiding this comment.
Do these source files include a build script? Or how would third party contributions work?
|
@JannisX11 I fix everything you mentioned. I removed the src sense it's human readable and really wasn't necessary ( You said I could but I had forgotten ). For 3rd Party contributions I want them to go to my own repo sense that's where I have been working on it. In that is the src and bundler GitHub repository. I made a few changes as well that you recommended |
|
Please make sure that plugin meta data in the plugin itself and in plugins.json match. The plugin is currently missing some fields such as tags, min_version and creation_date. |
|
@JannisX11 Done! |
Added "Meshy" plugin.
Adds support for the poly mesh format for bedrock entities ( new and old )
for exact details look at the read me