Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charts): add missing fido2Labels and fido2AdditionalAnnotations #7935

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix(charts): add missing fido2Labels and fido2AdditionalAnnotations #7935

merged 1 commit into from
Mar 4, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Mar 3, 2024 •
edited by mo-auto
Loading

Prepare

Description

Target issue

closes #7889

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Closes #7936,

@iromli iromli requested a review from moabu as a code owner March 3, 2024 21:02
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-charts-jans kind-bug Issue or PR is a bug in existing functionality labels Mar 3, 2024
@mo-auto
Copy link
Member

mo-auto commented Mar 3, 2024

Error: Hi @iromli, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto mo-auto mentioned this pull request Mar 3, 2024
Closed
@moabu moabu merged commit 7601a39 into main Mar 4, 2024
2 checks passed
@moabu moabu deleted the cn-fido2-ingress-labels branch March 4, 2024 09:02
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
@iromli
fix(charts): add missing fido2Labels and fido2AdditionalAnnotations (#…
ff72755 
…7935)

Signed-off-by: iromli <[email protected]>
Former-commit-id: 7601a39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-charts-jans kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
3 participants
@iromli @mo-auto @moabu