Jans fido2 replace requested parties 9248

[imran-ishaq]

Prepare

• Read PR guidelines
• Read license information

---

Description

Target issue

closes #9248

Implementation Details

---

Test and Document the changes

• Static code analysis has been run locally and issues have been fixed
• Relevant unit and integration tests have been added/updated
• Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

• I confirm that there is no impact on the docs due to the code changes in this PR.

[dryrunsecurity]

DryRun Security Summary

The pull request focuses on the implementation and testing of the FIDO2 authentication protocol in the Jans server and related components, including refactoring of the RequestedParties struct, addition of new test cases, updates to the FIDO plugin, and modification of the AttestationService class.

Expand for full summary

Summary:

The changes in this pull request are focused on the implementation and testing of the FIDO2 (Fast IDentity Online) authentication protocol in the Jans server and related components. The key changes include:

1. Refactoring of the RequestedParties struct in the fido2_config.go file, where the Name field has been renamed to Id and the Domains field has been renamed to Origins. This appears to be a structural change to better align with the FIDO2 specification.

2. Addition of new test cases in the AttestationServiceTest class, which verify the correct creation of Relying Party (RP) domains. These tests help ensure the security and reliability of the FIDO2 authentication process.

3. Updates to the FIDO plugin in the jans-cli-tui project, where the labels and field names for the "Requested Parties" feature have been changed to match the updated terminology (Name -> Id, Domains -> Origins).

4. Modification of the AttestationService class in the jans-fido2 project, where the createRpDomain method has been made public, potentially for use by other parts of the application.

From an application security perspective, these changes appear to be focused on improving the overall security and reliability of the FIDO2 implementation. The renaming of fields and updates to the test suite suggest an effort to align the codebase with the FIDO2 specification, which is a positive step. However, it's important to ensure that the changes do not introduce any unintended security vulnerabilities, particularly in the areas of RP domain validation, credential management, and the external interception feature.

Files Changed:

1. terraform-provider-jans/jans/fido2_config.go: The changes in this file involve the renaming of fields in the RequestedParties struct, which is part of the Fido2 configuration. This refactoring aligns the code with the FIDO2 specification.

2. jans-fido2/server/src/test/java/io/jans/fido2/service/AttestationServiceTest.java: The changes in this file add new test cases to verify the correct creation of Relying Party (RP) domains, which is an important aspect of the FIDO2 authentication process.

3. jans-cli-tui/cli_tui/plugins/020_fido/main.py: The changes in this file update the FIDO plugin to use the new field names (id and origins) for the "Requested Parties" feature, reflecting the updates made in the fido2_config.go file.

4. jans-fido2/server/src/main/java/io/jans/fido2/service/operation/AttestationService.java: The changes in this file make the createRpDomain method public, which could potentially allow it to be used by other parts of the application.

5. terraform-provider-jans/provider/resource_fido2_configuration_test.go: The changes in this file align with the updates made to the RequestedParties struct in the fido2_config.go file, renaming the Name field to Id and the Domains field to Origins.

Code Analysis

We ran 9 analyzers against 5 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.