Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] purchase_request: not allow to edit an approved purchase request #20

Merged

Conversation

alan196
Copy link

@alan196 alan196 commented Dec 16, 2024

This commit fixes the the following issue.

  • Create a purchase request with some products and send it to approval
  • The manager approves the purchase request.
  • After the approval the user can add new products to the request and can abuse

This commit fixes the the following issue.

- Create a purchase request with some products and send it to approval
- The manager approves the purchase request.
- After the approval the user can add new products to the request and can abuse
@alan196 alan196 merged commit 5536dbf into Jarsa:17.0 Dec 16, 2024
1 check failed
@jarsabot
Copy link

    **WARNING**: Could not link to Odoo task. Record ID not found in the title of the MR, supported formats:
{ record type }#{ number }

Available types: 'task#', 't#' (case insensitive)

Examples:

  • task#123

  • i#123

1 similar comment
@jarsabot
Copy link

    **WARNING**: Could not link to Odoo task. Record ID not found in the title of the MR, supported formats:
{ record type }#{ number }

Available types: 'task#', 't#' (case insensitive)

Examples:

  • task#123

  • i#123

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (17.0@b42e398). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             17.0      #20   +/-   ##
=======================================
  Coverage        ?   92.85%           
=======================================
  Files           ?        4           
  Lines           ?       42           
  Branches        ?        4           
=======================================
  Hits            ?       39           
  Misses          ?        0           
  Partials        ?        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants