Add up-to-date default workspace labels #709
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A followup to this pr would be to add some new workspace labels to identify some more common applications, but wanted to get the bases for this laid first :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They now are built from
defaultWindowTitleMap, which has also been extracted to avoid continuous instantiation, which should aid with memory usage.Additionally, I have also bundled into this pull request (but as a separate commit in case a different pr is better or the change is just not wanted) a patch to use iterators instead of always copying the mappings for the icons (workspaces + windows), which should further lower memory usage and provide optimizations for large mappings