Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

syntax error message improve #547

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

syntax error message improve #547

wants to merge 4 commits into from

Conversation

ThakeeNathees
Copy link
Collaborator

Description

Note that, the unit test for this PR is pending as makred it as WIP.

Now the alerts are printed with the visual location indication for the end user to understand cleanly. Here are the screen shots of the implementation and the old one.

Current:

syntax-error-pretty-print

Previous:

syntax-error-old

@ThakeeNathees ThakeeNathees mentioned this pull request Jul 30, 2024
Closed
@ThakeeNathees ThakeeNathees changed the title Thakee syntax error message syntax error message improve Jul 30, 2024
marsninja
marsninja suggested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@marsninja marsninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM save for 1 quick change, since we're now making the repo dependent on pytest lets add it to pyproject.toml dev dependencies.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marsninja marsninja marsninja requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThakeeNathees @marsninja