Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Expression type info #590

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Expression type info #590

wants to merge 4 commits into from

Conversation

ThakeeNathees
Copy link
Collaborator

Description

@ThakeeNathees ThakeeNathees force-pushed the thakee-expr-type-2 branch 2 times, most recently from d42cc95 to dae5363 Compare August 29, 2024 09:55
Copy link
Collaborator

@mgtm98 mgtm98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR @ThakeeNathees is trying to get all the types from all expressions in mypy and populate them back to Jac.
I have some arch. changes as follow

  • Make (AstSymbolNode::name_spec.sym_typ and Expr::expr_type) the same and this can be done through introduce a new AstTypedNode to be a common parent for Expr and AstSymbolNode

also note that this can only happen because of adding more types inside the ExpressionChecker visitors so that we can visit all the expressions and extract info from them. We need to review how all the visitor methods are created (dynamically created in run time) and we need to make sure that this won't degrade mypy

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ThakeeNathees
❌ mgtm98


mgtm98 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ThakeeNathees ThakeeNathees reopened this Sep 4, 2024
@ThakeeNathees ThakeeNathees changed the title Thakee expr type 2 Expression type info Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants