Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

91 api docs fix #92

Merged
merged 3 commits into from
Oct 22, 2023
Merged

91 api docs fix #92

merged 3 commits into from
Oct 22, 2023

Conversation

kenjim21
Copy link
Collaborator

Added the required themes and altered abspath to make submodules appear on Read the Docs site

@kenjim21 kenjim21 linked an issue Oct 21, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ec9bce) 93.11% compared to head (1911ccb) 93.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files           3        3           
  Lines         247      247           
=======================================
  Hits          230      230           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kenjim21 kenjim21 requested a review from Jashcraf October 22, 2023 03:14
Copy link
Owner

@Jashcraf Jashcraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like the large file changes were just in the html/css and associated binaries, just needed the edits and rtd theme on conf.py.

@Jashcraf Jashcraf merged commit a15947c into main Oct 22, 2023
3 checks passed
@Jashcraf Jashcraf deleted the 91-api-docs-fix branch December 15, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Docs Fix
2 participants