-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use insert .. on conflict
for bulk import operations
#3301
base: master
Are you sure you want to change the base?
Use insert .. on conflict
for bulk import operations
#3301
Conversation
I'm going to pull this down locally and try it first. Can't see any reason why this would fail offhand |
This is a breaking change because it requires rebuilding all generated code. Hmm, think this might have to wait for Marten 8. Which I do actually want to get to relatively soon-ish |
Hi @jeremydmiller, I have given this another pass. Bulk inserting now supports conditional overwrites - when in |
Updates the behaviour of
BulkInsertMode.OverwriteExisting
to useinsert ... on conflict do update
. This is one less db statement than before and a less prone to constraint issues.Also updates the behaviour of
BulkInsertMode.IgnoreDuplicates
to useinsert ... on conflict do nothing
.(Wasn't going to create this so soon but ran into an issue where spamming some seed data resulted in unique constraint violations when using
OverwriteExisting
)Tests pass but I had to delete the checked in generated code files. I am not sure what the correct way to regenerate these files is - can this be added to the doco somewhere so I can fix the issue myself next time 🙇 .