Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Upload component bug #238 #239

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+21 −136
Draft

File Upload component bug #238 #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2976b49
File Upload component bug #238
AnteSuvala Oct 4, 2024
def1102
fix: css; field overflowing
AnteSuvala Oct 4, 2024
0480d7c
fix: preview responsive to window size
AnteSuvala Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/lib/src/form-fields/autocomplete/autocomplete.wc.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
width: 100%;
height: 3rem;
user-select: none;
padding: 0 0.75rem;
padding-left: 0.75rem;
gap: 0.75rem;
background-color: transparent;
border: 1px solid var(--border-primary);
Expand Down
153 changes: 19 additions & 134 deletions packages/lib/src/form-fields/file-upload.wc.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
export let displayFormat = 'snake';
export let displayFormatFunction: (name: string) => string;


let previewStyle: string;
let bindingElement: HTMLDivElement;
let inputFocused: boolean = false;
Expand All @@ -41,7 +40,8 @@
let hoveringFile = false;
let internalValue: string;
let fileEl: HTMLInputElement;
let displayedFileNameString = (value && formatDisplayFileName(value, displayFormat, displayFormatFunction)) || '';
let displayedFileNameString =
(value && formatDisplayFileName(value, displayFormat, displayFormatFunction)) || '';

const dispatch = createEventDispatcher();

Expand Down Expand Up @@ -85,8 +85,12 @@
isLocal = true;
file = f;
internalValue = f.name;
displayedFileNameString = formatDisplayFileName(internalValue,displayFormat, displayFormatFunction) as string;

displayedFileNameString = formatDisplayFileName(
internalValue,
displayFormat,
displayFormatFunction
) as string;

if (file['type'].split('/')[0] === 'image') {
const base64 = (await convertBase64(file)) as string;
img = base64;
Expand Down Expand Up @@ -127,13 +131,11 @@
previewStyle = `
width: ${rect.width}px;
bottom: ${window.innerHeight - rect.top}px;
left: ${rect.width - 300}px;
`;
} else {
previewStyle = `
width: ${rect.width}px;
top: ${rect.bottom}px;
left: ${rect.width - 300}px;
`;
}
preview = !preview;
Expand Down Expand Up @@ -172,7 +174,7 @@
></div>
{:else}
{#if label && labelType == 'inside'}
<span class="field-label" class:move={inputFocused || internalValue}
<span class="field-label" class:move={inputFocused || displayedFileNameString}
>{@html displayLabel}</span
>
{/if}
Expand All @@ -197,7 +199,6 @@
</label>

<div class="field-icon preview-button" class:hidden={!img}>

<button type="button" on:click|preventDefault={() => showPreview()}>
<svg xmlns="http://www.w3.org/2000/svg" height="1rem" viewBox="0 0 576 512">
<path
Expand All @@ -215,6 +216,7 @@
img = '';
internalValue = '';
fileEl.value = '';
displayedFileNameString = '';
}}
>
<svg xmlns="http://www.w3.org/2000/svg" height="1rem" viewBox="0 0 512 512">
Expand Down Expand Up @@ -260,36 +262,16 @@
<style lang="postcss">
.field {
position: relative;
display: -webkit-box;
display: -webkit-flex;
display: -moz-box;
display: -ms-flexbox;
display: flex;
-webkit-box-orient: horizontal;
-webkit-box-direction: reverse;
-webkit-flex-direction: row-reverse;
-moz-box-orient: horizontal;
-moz-box-direction: reverse;
-ms-flex-direction: row-reverse;
flex-direction: row-reverse;
-webkit-box-align: center;
-webkit-align-items: center;
-moz-box-align: center;
-ms-flex-align: center;
align-items: center;
text-align: left;
width: 100%;
height: 3rem;
padding-right: 0.75rem;
-webkit-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
gap: 0.75rem;
background-color: transparent;
border: 1px solid var(--border-primary);
-webkit-border-radius: 0.25rem;
-moz-border-radius: 0.25rem;
border-radius: 0.25rem;
}

Expand All @@ -304,96 +286,46 @@

.field:focus-within {
border-color: var(--primary-color);
-webkit-box-shadow: inset 0 0 0 1px var(--primary-color);
-moz-box-shadow: inset 0 0 0 1px var(--primary-color);
box-shadow: inset 0 0 0 1px var(--primary-color);
}

.field-label {
position: absolute;
top: 50%;
left: 0.75rem;
-webkit-transform: translateY(-50%);
-moz-transform: translateY(-50%);
-ms-transform: translateY(-50%);
-o-transform: translateY(-50%);
transform: translateY(-50%);
font-size: 1rem;
-webkit-transition:
transform 0.3s,
top 0.3s,
font-size 0.3s;
-o-transition:
transform 0.3s,
top 0.3s,
font-size 0.3s;
-moz-transition:
transform 0.3s,
top 0.3s,
font-size 0.3s;
-webkit-transition:
top 0.3s,
font-size 0.3s,
-webkit-transform 0.3s;
transition:
top 0.3s,
font-size 0.3s,
-webkit-transform 0.3s;
-o-transition:
top 0.3s,
font-size 0.3s,
-o-transform 0.3s;
-moz-transition:
transform 0.3s,
top 0.3s,
font-size 0.3s,
-moz-transform 0.3s;
transition:
transform 0.3s,
top 0.3s,
font-size 0.3s;
transition:
transform 0.3s,
top 0.3s,
font-size 0.3s,
-webkit-transform 0.3s,
-moz-transform 0.3s,
-o-transform 0.3s;
}

.field-label.move {
top: 0.25rem;
-webkit-transform: translateY(0);
-moz-transform: translateY(0);
-ms-transform: translateY(0);
-o-transform: translateY(0);
transform: translateY(0);
font-size: 0.75rem;
}

.field-input {
-webkit-box-flex: 1;
-webkit-flex: auto;
-moz-box-flex: 1;
-ms-flex: auto;
flex: auto;
width: 10rem;
height: 100%;
height: 1rem;
font-size: 1rem;
width: 100%;
white-space: nowrap;
background: transparent;
overflow: hidden;
-o-text-overflow: ellipsis;
font-family: serif;
transform: translateY(0.8rem);
text-overflow: ellipsis;
border: none;
outline: none;
-webkit-border-radius: 0;
-moz-border-radius: 0;
border-radius: 0;
border-radius: 0.25rem;
background: transparent;
}

.field-input-padding {
padding: 1rem 0 0 0;
padding: 1.3rem 0.75rem 0.5rem 0;
transform: translateY(0);
}

.field-upload {
Expand All @@ -403,66 +335,34 @@
left: 0;
width: 100%;
height: 100%;
-webkit-border-radius: 0;
-moz-border-radius: 0;
border-radius: 0;
opacity: 0;
cursor: pointer;
}

.field-upload-container {
position: relative;
display: -webkit-box;
display: -webkit-flex;
display: -moz-box;
display: -ms-flexbox;
display: flex;
padding: 0 0.75rem;
height: 100%;
overflow: hidden;
-webkit-box-flex: 1;
-webkit-flex: 1;
-moz-box-flex: 1;
-ms-flex: 1;
flex: 1;
}

.field-icons {
z-index: 1;
position: relative;
display: -webkit-box;
display: -webkit-flex;
display: -moz-box;
display: -ms-flexbox;
display: flex;
-webkit-box-align: center;
-webkit-align-items: center;
-moz-box-align: center;
-ms-flex-align: center;
align-items: center;
gap: 0.375rem;
}

.field-icon {
display: -webkit-box;
display: -webkit-flex;
display: -moz-box;
display: -ms-flexbox;
display: flex;
-webkit-box-pack: center;
-webkit-justify-content: center;
-moz-box-pack: center;
-ms-flex-pack: center;
justify-content: center;
-webkit-box-align: center;
-webkit-align-items: center;
-moz-box-align: center;
-ms-flex-align: center;
align-items: center;
width: 2rem;
height: 2rem;
-webkit-border-radius: 50%;
-moz-border-radius: 50%;
border-radius: 50%;
cursor: pointer;
}
Expand All @@ -481,20 +381,8 @@
}

.field-icon button {
display: -webkit-box;
display: -webkit-flex;
display: -moz-box;
display: -ms-flexbox;
display: flex;
-webkit-box-pack: center;
-webkit-justify-content: center;
-moz-box-pack: center;
-ms-flex-pack: center;
justify-content: center;
-webkit-box-align: center;
-webkit-align-items: center;
-moz-box-align: center;
-ms-flex-align: center;
align-items: center;
width: 100%;
height: 100%;
Expand All @@ -509,14 +397,11 @@
position: absolute;
max-width: 300px;
max-height: 300px;
left: calc(100vw - 320px);
width: auto;
height: auto;
background-color: var(--background-primary);
-webkit-border-radius: 0.5rem;
-moz-border-radius: 0.5rem;
border-radius: 0.5rem;
-webkit-box-shadow: 0 3px 12px 3px rgba(0, 0, 0, 0.16);
-moz-box-shadow: 0 3px 12px 3px rgba(0, 0, 0, 0.16);
box-shadow: 0 3px 12px 3px rgba(0, 0, 0, 0.16);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/lib/src/form-fields/input/input.wc.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
}

&.jp-input-field-padding {
padding: 0 0.75rem 0.5rem 0;
padding: 0 0.75rem 0.5rem 0.75rem;
transform: translateY(-0.5rem);
}

Expand Down