Adding nullability to project

.github/workflows/ci.yml

@@ -17,12 +17,14 @@ jobs:
       uses: actions/setup-dotnet@v3
       with:
         dotnet-version: 8.0.x
+    - name: Format Code
+      run: dotnet format analyzers Content/CarterService.sln --verbosity diagnostic
     - name: Build Source
-      run: dotnet build Content/src/CarterService.csproj -v quiet --configuration Release
+      run: dotnet build Content/src/CarterService.csproj --configuration Release
     - name: Build Tests
-      run: dotnet build Content/src/CarterService.csproj -v quiet --configuration Release
+      run: dotnet build Content/tests/CarterService.Tests.csproj --configuration Release
     - name: Test
-      run: dotnet test Content/tests/CarterService.Tests.csproj -v quiet --configuration Release
+      run: dotnet test Content/tests/CarterService.Tests.csproj --configuration Release
 env:
   DOTNET_CLI_TELEMETRY_OPTOUT: 1
   DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1

Content/src/CarterService.csproj

@@ -4,6 +4,7 @@
     <AssemblyName>CarterService</AssemblyName>
     <OutputType>Exe</OutputType>
     <LangVersion>Latest</LangVersion>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
   <ItemGroup>
     <None Remove=".editorconfig" />

Content/src/Entities/Internal/AppSettings.cs

@@ -1,12 +1,12 @@
-namespace CarterService.Entities;
+namespace CarterService.Entities.Internal;
 
 /// <summary>
 /// This is obtained from the appsettings.json on Startup
 /// </summary>
 public record AppSettings
 {
-    public CacheConfig Cache { get; init; }
-    public RouteDefinition RouteDefinition { get; init; }
-    public HealthDefinition HealthDefinition { get; init; }
-    public string[] ServerUrls { get; init; }
+    public CacheConfig Cache { get; init; } = new();
+    public RouteDefinition RouteDefinition { get; init; } = new();
+    public HealthDefinition HealthDefinition { get; init; } = new();
+    public string[] ServerUrls { get; init; } = [];
 }

Content/src/Entities/Internal/CacheConfig.cs

@@ -1,4 +1,4 @@
-namespace CarterService.Entities;
+namespace CarterService.Entities.Internal;
 
 public record CacheConfig
 {

Content/src/Entities/Internal/FailedResponse.cs

@@ -1,23 +1,23 @@
 using System;
 
-namespace CarterService.Entities;
+namespace CarterService.Entities.Internal;
 
 public record FailedResponse
 {
     public FailedResponse(Exception ex)
     {
         Message = ex.Message;
 #if DEBUG
-        StackTrace = ex.StackTrace;
-        Source = ex.Source;
-        TargetMethod = ex.TargetSite.Name;
+        StackTrace = ex.StackTrace ?? string.Empty;
+        Source = ex.Source ?? string.Empty;
+        TargetMethod = ex.TargetSite?.Name ?? string.Empty;
 #endif
     }
 
     public string Message { get; set; }
 #if DEBUG
-    public string StackTrace { get; set; }
-    public string Source { get; set; }
-    public string TargetMethod { get; set; }
+    public string StackTrace { get; set; } = string.Empty;
+    public string Source { get; set; } = string.Empty;
+    public string TargetMethod { get; set; } = string.Empty;
 #endif
 }

Content/src/Entities/Internal/HealthDefinition.cs

@@ -1,9 +1,9 @@
-namespace CarterService.Entities;
+namespace CarterService.Entities.Internal;
 
 public record HealthDefinition
 {
-    public string Endpoint { get; init; }
-    public string Name { get; init; }
-    public string HealthyMessage { get; init; }
-    public string[] Tags { get; init; }
+    public string Endpoint { get; init; } = string.Empty;
+    public string Name { get; init; } = string.Empty;
+    public string HealthyMessage { get; init; } = string.Empty;
+    public string[] Tags { get; init; } = [];
 }

Content/src/Entities/Internal/RouteDefinition.cs

@@ -1,7 +1,7 @@
-namespace CarterService.Entities;
+namespace CarterService.Entities.Internal;
 
 public record RouteDefinition
 {
-    public string RouteSuffix { get; init; }
-    public string Version { get; init; }
+    public string RouteSuffix { get; init; } = string.Empty;
+    public string Version { get; init; } = string.Empty;
 }

Content/src/Extensions/HttpContextExtensions.cs

@@ -3,7 +3,7 @@
 using Carter.Cache;
 using Carter.ModelBinding;
 using Carter.Response;
-using CarterService.Entities;
+using CarterService.Entities.Internal;
 using Microsoft.AspNetCore.Http;
 
 namespace CarterService.Extensions;

Content/src/Extensions/TypeExtensions.cs

@@ -22,7 +22,7 @@ public static class TypeExtensions
     internal static Type GetAnyElementType(this Type type)
     {
         if (type.IsArray)
-            return type.GetElementType();
+            return type.GetElementType()!;
 
         if (type.IsGenericType && type.GetGenericTypeDefinition() == typeof(IEnumerable<>))
             return type.GetGenericArguments()[0];

Content/src/Extensions/WebApplicationBuilderExtensions.cs

@@ -1,5 +1,5 @@
 using Carter.OpenApi;
-using CarterService.Entities;
+using CarterService.Entities.Internal;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Diagnostics.HealthChecks;

Content/src/Modules/HelloModule.cs

@@ -1,8 +1,8 @@
 using Carter;
 using Carter.OpenApi;
-using CarterService.Entities;
+using CarterService.Entities.Internal;
 using CarterService.Extensions;
-using CarterService.Repository;
+using CarterService.Repositories;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Routing;

Content/src/Modules/MainModule.cs

@@ -1,6 +1,6 @@
 using System.Threading.Tasks;
 using Carter;
-using CarterService.Entities;
+using CarterService.Entities.Internal;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Routing;

Content/src/Program.cs

@@ -1,8 +1,8 @@
 using Carter;
 using Carter.Cache;
-using CarterService.Entities;
+using CarterService.Entities.Internal;
 using CarterService.Extensions;
-using CarterService.Repository;
+using CarterService.Repositories;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.Extensions.Configuration;

Content/src/Repositories/HelloRepository.cs

@@ -1,4 +1,4 @@
-namespace CarterService.Repository;
+namespace CarterService.Repositories;
 
 public class HelloRepository : IHelloRepository
 {

Content/src/Repositories/IHelloRepository.cs

@@ -1,4 +1,4 @@
-namespace CarterService.Repository;
+namespace CarterService.Repositories;
 
 public interface IHelloRepository
 {

Content/src/appsettings.Development.json

@@ -5,8 +5,7 @@
     "WriteTo": [
       { "Name": "Console" }
     ],
-    "Enrich": [ "FromLogContext", "WithMachineName", "WithThreadId" ],
-    "AllowedHosts": "*"
+    "Enrich": [ "FromLogContext", "WithMachineName", "WithThreadId" ]
   },
   "AppSettings": {
     "Cache": {

Content/src/appsettings.json

@@ -5,8 +5,7 @@
     "WriteTo": [
       { "Name": "Console" }
     ],
-    "Enrich": [ "FromLogContext", "WithMachineName", "WithThreadId" ],
-    "AllowedHosts": "*"
+    "Enrich": [ "FromLogContext", "WithMachineName", "WithThreadId" ]
   },
   "AppSettings": {
     "Cache": {

Content/tests/CarterService.Tests.csproj

@@ -4,6 +4,7 @@
     <TargetFramework>net8.0</TargetFramework>
     <LangVersion>Latest</LangVersion>
     <IsPackable>false</IsPackable>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>

Content/tests/Unit/HelloTests.cs

@@ -2,7 +2,7 @@
 using System.Net;
 using System.Net.Http;
 using System.Threading.Tasks;
-using CarterService.Repository;
+using CarterService.Repositories;
 using Microsoft.AspNetCore.Mvc.Testing;
 using Microsoft.Extensions.DependencyInjection;
 using Xunit;