Skip to content

Commit

Permalink
fix: remove system level zsh
Browse files Browse the repository at this point in the history
The coexistence of zsh in both system and home manager causes
significant speed issues as per: nix-community/home-manager#910
  • Loading branch information
JayRovacsek committed Oct 8, 2024
1 parent 2d341d0 commit b3a0f0b
Show file tree
Hide file tree
Showing 21 changed files with 51 additions and 48 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,8 @@

- *(packages)* Resolve broken packages - ([74fbe6f](https://github.com/JayRovacsek/nix-config/commit/74fbe6fcbe1046512778970f6b47f4bbb8709a7f))

- *(packages,hydra)* Remove bedrock server package, add uris to hydra - ([2d341d0](https://github.com/JayRovacsek/nix-config/commit/2d341d08008a60b6c38159195887058a9c680f18))

- *(static)* Update build configs - ([3ab0dda](https://github.com/JayRovacsek/nix-config/commit/3ab0ddaa8eb135235b02bf9988379926476bead2))

- *(tooling)* Add scopes to conform configuration - ([99a07f5](https://github.com/JayRovacsek/nix-config/commit/99a07f59513cfd6824a8d21875d4c8f95356f88d))
Expand Down
24 changes: 24 additions & 0 deletions common/config.nix
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,30 @@ _: {
address = "192.168.17.2";
fqdn = "minecraft.local";
}
{
address = "192.168.17.2";
fqdn = "geo.hivebedrock.network";
}
{
address = "192.168.17.2";
fqdn = "hivebedrock.network";
}
{
address = "192.168.17.2";
fqdn = "play.inpvp.net";
}
{
address = "192.168.17.2";
fqdn = "mco.lbsg.net";
}
{
address = "192.168.17.2";
fqdn = "play.galaxite.net";
}
{
address = "192.168.17.2";
fqdn = "play.enchanted.gg";
}
{
address = "192.168.17.2";
fqdn = "palworld.local";
Expand Down
3 changes: 1 addition & 2 deletions common/images/amazon.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@
let
inherit (self.common.system) unstable-system;
inherit (self.common.package-sets) x86_64-linux-unstable;
inherit (self.nixosModules) amazon-image zsh;
inherit (self.nixosModules) amazon-image;

inherit (x86_64-linux-unstable) system identifier pkgs;
base = self.common.modules.${identifier};
modules = base ++ [
../../hosts/ditto
amazon-image
zsh
];
specialArgs = {
inherit self;
Expand Down
3 changes: 1 addition & 2 deletions common/images/oracle.nix
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{ self }:
let
inherit (self.common.system) unstable-system;
inherit (self.nixosModules) disable-assertions oracle-image zsh;
inherit (self.nixosModules) disable-assertions oracle-image;
inherit (self.common.package-sets) x86_64-linux-unstable;

inherit (x86_64-linux-unstable) system identifier pkgs;
Expand All @@ -10,7 +10,6 @@ let
../../hosts/ditto
disable-assertions
oracle-image
zsh
];
specialArgs = {
inherit self;
Expand Down
1 change: 0 additions & 1 deletion home-manager-modules/alacritty/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ in
programs.alacritty = {
enable = true;
settings = {
shell.program = "${pkgs.zsh}/bin/zsh";
window = {
dimensions = {
columns = 0;
Expand Down
11 changes: 4 additions & 7 deletions home-manager-modules/broot/default.nix
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
{ config, osConfig, ... }:
{ config, ... }:
let
enable = true;

enableBashIntegration =
config.programs.bash.enable && osConfig.programs.bash.enable;
enableFishIntegration =
config.programs.fish.enable && osConfig.programs.fish.enable;
enableZshIntegration =
config.programs.zsh.enable && osConfig.programs.zsh.enable;
enableBashIntegration = config.programs.bash.enable;
enableFishIntegration = config.programs.fish.enable;
enableZshIntegration = config.programs.zsh.enable;

settings.modal = true;

Expand Down
11 changes: 4 additions & 7 deletions home-manager-modules/direnv/default.nix
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
{ config, osConfig, ... }:
{ config, ... }:
let
enable = true;
enableBashIntegration =
config.programs.bash.enable && osConfig.programs.bash.enable;
enableFishIntegration =
config.programs.fish.enable && osConfig.programs.fish.enable;
enableZshIntegration =
config.programs.zsh.enable && osConfig.programs.zsh.enable;
enableBashIntegration = config.programs.bash.enable;
enableFishIntegration = config.programs.fish.enable;
enableZshIntegration = config.programs.zsh.enable;

nix-direnv.enable = true;

Expand Down
8 changes: 3 additions & 5 deletions home-manager-modules/hstr/default.nix
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
{ config, osConfig, ... }:
{ config, ... }:
let
enable = true;

enableBashIntegration =
config.programs.bash.enable && osConfig.programs.bash.enable;
enableZshIntegration =
config.programs.zsh.enable && osConfig.programs.zsh.enable;
enableBashIntegration = config.programs.bash.enable;
enableZshIntegration = config.programs.zsh.enable;

in
{
Expand Down
2 changes: 1 addition & 1 deletion home-manager-modules/hyprland/settings.nix
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ let
extra = "transform,1";
}
{
name = "DP-2";
name = "DP-4";
resolution = "1920x1080";
position = "1080x420";
scale = "1";
Expand Down
11 changes: 4 additions & 7 deletions home-manager-modules/nix-index/default.nix
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
{ config, osConfig, ... }:
{ config, ... }:
let
enable = true;

enableBashIntegration =
config.programs.bash.enable && osConfig.programs.bash.enable;
enableFishIntegration =
config.programs.fish.enable && osConfig.programs.fish.enable;
enableZshIntegration =
config.programs.zsh.enable && osConfig.programs.zsh.enable;
enableBashIntegration = config.programs.bash.enable;
enableFishIntegration = config.programs.fish.enable;
enableZshIntegration = config.programs.zsh.enable;

in
{
Expand Down
11 changes: 4 additions & 7 deletions home-manager-modules/starship/default.nix
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
{ config, osConfig, ... }:
{ config, ... }:
let
enable = true;
enableBashIntegration =
config.programs.bash.enable && osConfig.programs.bash.enable;
enableFishIntegration =
config.programs.fish.enable && osConfig.programs.fish.enable;
enableZshIntegration =
config.programs.zsh.enable && osConfig.programs.zsh.enable;
enableBashIntegration = config.programs.bash.enable;
enableFishIntegration = config.programs.fish.enable;
enableZshIntegration = config.programs.zsh.enable;
in
{
programs.starship = {
Expand Down
2 changes: 2 additions & 0 deletions home-manager-modules/zsh/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ let
};
in
{
home.sessionVariables.SHELL = "${lib.getExe config.programs.zsh.package}";

programs.zsh = {
autosuggestion.enable = true;
enable = true;
Expand Down
1 change: 0 additions & 1 deletion hosts/alakazam/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ in
tmux
udev
zramSwap
zsh
];

age = {
Expand Down
1 change: 0 additions & 1 deletion hosts/butterfree/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ in
ssm
time
timesyncd
zsh
];

networking.hostName = "butterfree";
Expand Down
1 change: 0 additions & 1 deletion hosts/dragonite/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ in
unifi
zfs
zramSwap
zsh
];

age = {
Expand Down
1 change: 0 additions & 1 deletion hosts/gastly/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ in
timesyncd
udev
zramSwap
zsh
];

age = {
Expand Down
1 change: 0 additions & 1 deletion hosts/jigglypuff/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ in
time
timesyncd
zramSwap
zsh
];

networking = {
Expand Down
1 change: 0 additions & 1 deletion hosts/mew/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ in
nix
time
timesyncd
zsh
];

networking = {
Expand Down
1 change: 0 additions & 1 deletion hosts/victreebel/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ in
ssh
time
yabai
zsh
];

networking = {
Expand Down
1 change: 0 additions & 1 deletion hosts/zubat/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ in
nix-topology
time
timesyncd
zsh
self.inputs.nixos-wsl.nixosModules.wsl
];

Expand Down
2 changes: 1 addition & 1 deletion lib/users.nix
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ let
# this file.
flippedRecursiveUpdate overrides {
users.users.${name} = recursiveUpdate {
shell = if name != "builder" then pkgs.zsh else pkgs.bash;
shell = pkgs.bash;
home = if isDarwin then "/Users/${name}" else "/home/${name}";
} stripped-user-settings;

Expand Down

0 comments on commit b3a0f0b

Please sign in to comment.