API: refactor webapp to make use of FastAPI dependecy injection #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is a draft. i wanted to get some early feedback to see if this changes is acceptable. i still need to refactor the test suite. this change will replace most of the refactoring done in #206 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| fetch_sealed_secrets_cert() | ||
| if settings.kubeseal_autofetch: | ||
| with open(settings.kubeseal_cert, "w") as file: | ||
| LOGGER.info("Saving certificate in '%s'", settings.kubeseal_cert) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
| for secret in data.secrets: | ||
| LOGGER.info( | ||
| "Sealing secret '%s.%s' for namespace '%s' with scope '%s'.", | ||
| data.secret, |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
UiP9AV6Y
force-pushed
the
feature_api_di
branch
2 times, most recently
from
09d0a1b to
92d9908
Compare
unify all interaction with the kubernetes API and the kubeseal binaries in reusable clients, which exist as mock and as productive implementations. the clients are injected using the FastAPI dependency injection system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unify all interaction with the kubernetes API and the kubeseal binaries in reusable clients, which exist as mock and as productive implementations. the clients are injected using the FastAPI dependency injection system