Fix sound & mic state update

Jean-Tinland · Dec 24, 2023 · 93c901f · 93c901f
1 parent 73d6595
commit 93c901f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/components/data/mic.jsx b/lib/components/data/mic.jsx
@@ -56,10 +56,13 @@ export const Widget = React.memo(() => {
   }, [dragging, volume]);
 
   React.useEffect(() => {
-    if (_volume && parseInt(_volume, 10) !== volume) {
-      setVolume(parseInt(_volume, 10));
-    }
-  }, [_volume, volume]);
+    setVolume((currentVolume) => {
+      if (_volume && currentVolume !== parseInt(_volume, 10)) {
+        return parseInt(_volume, 10);
+      }
+      return currentVolume;
+    });
+  }, [_volume]);
 
   if (loading) return <DataWidgetLoader.Widget className="mic" />;
   if (!state || volume === undefined || _volume === "missing value")

diff --git a/lib/components/data/sound.jsx b/lib/components/data/sound.jsx
@@ -68,6 +68,7 @@ export const Widget = React.memo(() => {
       if (_volume && currentVolume !== parseInt(_volume, 10)) {
         return parseInt(_volume, 10);
       }
+      return currentVolume;
     });
   }, [_volume]);