Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only show minimum if it is bigger than 0 #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fuddl
Copy link

@fuddl fuddl commented Oct 31, 2019

I think the headers are unnecessary when the threshold is 0

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #3 into master will decrease coverage by 1.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage    71.8%   70.68%   -1.13%     
==========================================
  Files           3        3              
  Lines         376      382       +6     
  Branches       54       56       +2     
==========================================
  Hits          270      270              
- Misses         97      103       +6     
  Partials        9        9
Impacted Files Coverage Δ
integraality/property_statistics.py 73.52% <0%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46484f5...f09c3fe. Read the comment docs.

@JeanFred JeanFred self-requested a review November 4, 2019 17:29
@JeanFred
Copy link
Owner

JeanFred commented Nov 4, 2019

Thanks for the contribution @fuddl! I think it makes sense :)

That part of the code was untested so I have just added some in 588dae8. Would you mind rebasing on the latest master?
If you feel up for it, you can also add another test that would cover this new behaviour (if not, that’s fine, I would do it myself :) )

@fuddl
Copy link
Author

fuddl commented Nov 5, 2019

I have no idea how to rebase branches accross forks 😅

But i'll find out

@JeanFred
Copy link
Owner

JeanFred commented Nov 5, 2019

I have no idea how to rebase branches accross forks sweat_smile

But i'll find out
No worries, let me know if I can help :)

Off the top of my head, and assuming my repo is still the origin remote, it’s probably, from your branch something like
git fetch origin && git rebase origin/master

@JeanFred JeanFred force-pushed the master branch 2 times, most recently from d28793a to 6963040 Compare April 24, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants