Image instruction #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
force-pushed
the
image-instruction
branch
17 times, most recently
from
daf8894 to
12ed0fc
Compare
JeanMeche
force-pushed
the
image-instruction
branch
2 times, most recently
from
f5c1402 to
58e3f50
Compare
Updating `build-tooling` and `docs`. PR Close angular#56946
Replace loose equality (==) with strict equality (===) for the 'code' variable. This change ensures type safety and prevents unintended type coercion. PR Close angular#56944
This commit fixes that the angular.dev deployment is subject to GitHub API rate limiting due to lack of an access token. This commit fixes this, similar to how we fixed it in `angular/components`. The token is pure read-only. PR Close angular#56929
This would allow me & ben to review some of the changes on the 17.3 branch, for example the redirections. PR Close angular#56952
JeanMeche
force-pushed
the
image-instruction
branch
from
58e3f50 to
9b341ee
Compare
…ular#56973) This commit adds support for extracting call signals from interfaces. fixes angular#56969 PR Close angular#56973
This fixes the case that common module is removed on a second run of the migration. We were not looking at block parameters for common module usage. PR Close angular#56968
… 5.4 (angular#56961) In angular#56358 we removed most of the places that untag the references to typecheck files, because it was causing the compiler to throw error when it produces diagnostics. This appears to have caused a regression in TS 5.4 which now emits the synthetic references. These changes add tagging right before the program emits. Fixes angular#56945. PR Close angular#56961
Material 18.1 includes a fix we were waiting for adev. Fixes angular#56786 PR Close angular#56960
…gular#57081) fix(docs-infra): skip navigation to card if user clicks on anchor If user clicks on anchor inside member card (Reference) then skip navigation to card section and allow to navigate to anchor link. Use correct RxJs operator. Fix DI: destroy ReferenceScrollHandler when navigate outside of reference pages. fix: scroll to the of the card only after click on card header fix: remove import of filter operator PR Close angular#57081
*Fixing broken documentation reference to HammerLoader in HammerLoaderInjectionToken page PR Close angular#55836
…r#57060) This commit allows configuring `NgZone` through the providers for `bootstrapModule`. Prior to this change, developers had to configure `NgZone` in the `BootstrapOptions`. PR Close angular#57060
…ion and bootstrapModule (angular#57060) This commit de-duplicates the code for bootstrapping between `bootstrapApplication` and `bootstrapModule`. A majority of the bootstrap code was identical between the two, with some minor differences that can be handled with a function overload. PR Close angular#57060
…otstrapModule (angular#57060) This commit adds the `ImagePerformanceWarning` to the common bootstrap code rather than only starting it when using `bootstrapApplication`. PR Close angular#57060
…ar#57060) It no longer requires ngZone: 'noop' because NgZone can be configured in providers PR Close angular#57060
…in tests (angular#57153) This creates a private option that can be used internally while we migrate this to the default and only behavior. ~200 tests in TGP have errors that are being swallowed (console.log) and not causing the test to fail. We can first explicitly opt those out, flip the default internally, then "fix" them by adding expect...toThrow. PR Close angular#57153
…ngular#57186) Rather than leaving the timers around as no-ops, this commit updates the logic to also attempt to clear or cancel the timers. This is helpful for the eventual goal of running the scheduler in the `fakeAsync` zone (if the test is running in `fakeAsync`) rather than scheduling in the root zone and making it impossible to flush. PR Close angular#57186
…s to be lazy loaded (angular#56428) This schematic helps developers to convert eagerly loaded component routes to lazy loaded routes PR Close angular#56428
This new contributor guide includes information for authoring Angular documentation. PR Close angular#56505
See associated pull request for more information. PR Close angular#57150
…t: true` (angular#57212) This commit is similar to 98ed5b6, and makes use of the preparation work implemented there. Similar to directives and components marked via `jit: true`, we also need to do the same for JIT marked `@NgModule` classes. This is mostly important for downleveling of decorators to support dependency injection of such classes. Inside Google3, migrating from `ts_library` to `ng_module` turns of decorator downleveling, so the `jit: true` for NgModule's is implicitly requesting/reliant on this transform— as expected. PR Close angular#57212
The new package comes with types by default, and also has a nicer API. The old package had broken types and couldn't be used anymore; and it's deprecated/unmaintained. We did a similar switch in angular/dev-infra. PR Close angular#57205
See associated pull request for more information. PR Close angular#57205
Lock file maintenance updated Terser, which impacts the bundle optimizations being tested via the symbol golden tests. There was a small noticable change in the symbol golden where `withDomHydration` is now preserved, and the underlying function that was previously detected is gone. Seemingly Terser now inlines this function and had to preserve `withDomHydration` as the entry point. PR Close angular#57205
This may help with detecting the license of google-protobuf- which is a transitive dependency of `@bazel/worker` PR Close angular#57205
…gular#55805) This change is a proof of concept of how the new Chrome DevTools Performance extension API (https://bit.ly/rpp-e11y) can be used to surface Angular runtime data directly in the Chrome DevTools Performance panel. Specifically, it implements the following changes: 1. Use the profiling status notification API to toggle the Timing API: The notification API is implemented under the chrome.devtools.performance extension namespace and consits of two events: ProfilingStarted and ProfilingStopped, dispatched when the Performance panel has started and stopped recording, respectively. This API is used to enable the Timings API when the recording has started in the Performance panel and disable it when recording has stopped. 2. Use the User Timings `detail` field format specification of the Performance extension API (https://developer.mozilla.org/en-US/docs/Web/API/Performance_API/User_timing) to inject data collected by the Angular Profiler into the Performance panel timeline. Angular Profiler uses several hooks to measure framework tasks like change detection. With this change, this measurements are visible in the same context as the runtime data collected by the browser in the Performance Panel timeline. Note: to enable the user timings to be collected in the first place, one needs to open the Angular DevTools panel so that the related artifacts are loaded in the page. This shortcoming can be fixed in a follow up so that the extra step isn't necessary. PR Close angular#55805
This updates the search dialog component to use signal APIs PR Close angular#57215
JeanMeche
force-pushed
the
image-instruction
branch
from
b005279 to
b18e0f2
Compare
…gex with g flag (angular#57232) Use the g flag in replace to perform a replaceAll PR Close angular#57232
…actory and local variables (angular#57181)" (angular#57230) This reverts commit 67e0940. PR Close angular#57230
Expression that return iterables can now be spreaded if needed.
JeanMeche
force-pushed
the
image-instruction
branch
from
b18e0f2 to
515bb3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.