Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding helicity values to the chargeTree.json #276

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

jwgibbs
Copy link
Contributor

@jwgibbs jwgibbs commented Feb 13, 2025

Added feature to buildChargeTree.groovy that opens the monitor.hipo files for each run, gets the values from the helicity histograms, and puts hte values in the json file.

…iles for each run, gets the values from the helicity histograms, and puts hte values in the json file
@c-dilks
Copy link
Member

c-dilks commented Feb 13, 2025

We should also add a connecting arrow to the documentation flowchart, to indicate this script needs a new input file

https://github.com/JeffersonLab/clas12-timeline/blob/main/qa-physics/docs/docDiagram.md#flowchart

Adding this around line 81 should do it:

      outmonFiles --> buildCT

Messy code needs a messy diagram... :)

@c-dilks c-dilks linked an issue Feb 14, 2025 that may be closed by this pull request
@c-dilks
Copy link
Member

c-dilks commented Feb 14, 2025

Thanks!

Now we need to re-run RG-C Summer 2022 QA timelines, to update its chargeTree.json. I believe this is the only run group that needs this; if other datasets need it, we can update their chargeTree.json files upon request.

I'll take care of this and will submit a PR in cla12-qadb.

@c-dilks c-dilks merged commit 3294722 into JeffersonLab:main Feb 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add helicity-latched charge, and propagate it to QADB
2 participants