Change range and inital values for the fit function for forward Vz for RG-D. Apply the double gaussian fit only for solid target. #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r RG-D. Apply the double gaussian fit only for solid target.
c-dilks
reviewed
Feb 14, 2025
detectors/src/main/java/org/jlab/clas/timeline/fitter/ForwardFitter.groovy
Outdated
Show resolved
Hide resolved
c-dilks
reviewed
Feb 14, 2025
detectors/src/main/java/org/jlab/clas/timeline/fitter/ForwardFitter.groovy
Outdated
Show resolved
Hide resolved
c-dilks
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the range for the fit for the BiModal function to fit only the two peaks.
I have also changed the initial values for the fits.
I have added an if statement to apply the double Gaussian only on solid targets for RG-D.