Add some checks in SimpleGBLTrajAliDriver etc #1038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbutti
requested changes
May 17, 2024
tracking/src/main/java/org/hps/recon/tracking/gbl/SimpleGBLTrajAliDriver.java
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/gbl/SimpleGBLTrajAliDriver.java
Show resolved
Hide resolved
tracking/src/main/java/org/hps/recon/tracking/gbl/SimpleGBLTrajAliDriver.java
Show resolved
Hide resolved
…ompact builder skip over non existent MPII ids
|
detector.properties has not been updated properly for most of these detectors. Not sure we want to add every iteration you did while aligning to the master branch. We should chat about what all from this PR we want to include. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SimpleGBLTrajAliDriver:
Add a check that trackGblStripClusterData is filled.
Checks that global derivatives don't contain a NaN.
In GBLOutputDriver:
Change range on Chi2oNDF so that details can be seen