Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classes for skimming recon events and a possible V0 skim setup #1086

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Classes for skimming recon events and a possible V0 skim setup #1086

wants to merge 3 commits into from

Conversation

bloodyyugo
Copy link
Contributor

closes issue #1085

@bloodyyugo bloodyyugo linked an issue Mar 4, 2025 that may be closed by this pull request
Add capability to skim events to different streams & add potential v0 skim code for 10% #1085
Open
mgignac
mgignac approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@mgignac mgignac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me, thanks! Of course this will need to be tested. One thing we may need to confirm is whether the cuts are valid across all runs, but that can be confirmed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgignac mgignac mgignac approved these changes

@sarahgaiser sarahgaiser Awaiting requested review from sarahgaiser

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add capability to skim events to different streams & add potential v0 skim code for 10%
2 participants
@bloodyyugo @mgignac