Added Fiducial Cut Algorithm #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-dilks
reviewed
May 22, 2024
…ngs': false to meson.build
c-dilks
reviewed
May 29, 2024
c-dilks
reviewed
May 29, 2024
| @@ -7,6 +7,7 @@ | |||
| #include <variant> | |||
| #include <vector> | |||
|
|
|||
| #include <fmt/ranges.h> | |||
There was a problem hiding this comment.
we can probably remove this, since it's in Logger.h now
Suggested change
| #include <fmt/ranges.h> | |
| #include <fmt/ranges.h> |
c-dilks
reviewed
May 29, 2024
Comment on lines
+47
to
+52
| /// @action_function{scalar filter} checks if the particle passes fiducial cuts | ||
| /// @param traj_row data struct of the particle in REC::Traj | ||
| /// @param torus toroidal magnetic field sign | ||
| /// @param pid pid of the particle | ||
| /// @returns `true` if passes fiducial cuts | ||
| bool Filter(FiducialFilter::traj_row_data const traj_row, int const torus, int const pid) const; |
There was a problem hiding this comment.
This isn't an action function, since traj_row is not a simple scalar. Perhaps you need a vector action function here; I believe it would be the first (see #169). For this PR, I recommend:
- change the docstring so that it's not registering as an action function (remove
@action_function{scalar filter}) - open an issue saying
FiducialCutslacks an action function
There was a problem hiding this comment.
We need better documentation on what an action function is, exactly; added to #141
c-dilks
reviewed
May 29, 2024
| hipo::banklist::size_type b_config; | ||
|
|
||
| /// Pi | ||
| const double PI = 3.14159265; |
There was a problem hiding this comment.
Suggested change
| const double PI = 3.14159265; | |
| const double PI = M_PI; |
or replace PI with M_PI everywhere
c-dilks
reviewed
May 30, 2024
|
|
||
| /// @brief_algo Filter the `REC::Particle` bank by applying DC (drift chamber) fiducial cuts | ||
| /// | ||
| /// @begin_doc_algo{Filter} |
There was a problem hiding this comment.
new docstring syntax (#223)
Suggested change
| /// @begin_doc_algo{Filter} | |
| /// @begin_doc_algo{clas12::FiducialFilter | Filter} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Fiducial Cut algorithm that handles pid==11,211,-211,2212 drift chamber cuts using REC::Traj bank data
Currently only using pass1 parameterization
meson test validator-clas12-FiducialFilter --verbose --test-args '\-f /cache/clas12/rg-a/production/recon/fall2018/torus-1/pass1/v1/dst/train/nSidis/nSidis_005036.hipo \-n 0 \-o ../validator_output'outputs before and after REC::Traj [x,y] 2d histograms for each drift chamber number. Below is the result for DC1Before Fiducial Cuts
After Fiducial Cuts