LeptonID #232
Draft
LeptonID #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-dilks
reviewed
Jul 1, 2024
Comment on lines
9
to
18
| double P; | ||
| double Theta; | ||
| double Phi; | ||
| double SFpcal; | ||
| double SFecin; | ||
| double SFecout; | ||
| double m2pcal; | ||
| double m2ecin; | ||
| double m2ecout; | ||
| double score; |
There was a problem hiding this comment.
Either each one of these members needs to be documented, or you can use @doxygen_off and @doxygen_on to avoid having to write documentation here.
Comment on lines
21
to
34
| /// | ||
| /// @brief_algo This is a template algorithm, used as an example showing how to write an algorithm. | ||
| /// | ||
| /// Provide a more detailed description of your algorithm here. | ||
| /// | ||
| /// @begin_doc_algo{clas12::LeptonIDFilter | Filter} | ||
| /// @input_banks{REC::Particle} | ||
| /// @output_banks{REC::Particle} | ||
| /// @end_doc | ||
| /// | ||
| /// @begin_doc_config | ||
| /// @config_param{exampleInt | int | an example `integer` configuration parameter} | ||
| /// @config_param{exampleDouble | double | an example `double` configuration parameter} | ||
| /// @end_doc |
There was a problem hiding this comment.
Don't forget to document this algorithm; see other algorithms for examples.
Co-authored-by: Christopher Dilks <[email protected]>
c-dilks
reviewed
Jul 3, 2024
Comment on lines
+81
to
+115
| //Create TMVA reader | ||
| TMVA::Reader *readerTMVA = new TMVA::Reader(); | ||
|
|
||
| ///Set of variables for the reader | ||
| ///Momentum | ||
| Float_t P; | ||
| ///Theta angle | ||
| Float_t Theta; | ||
| ///Phi angle | ||
| Float_t Phi; | ||
| ///Sampling fraction on the PCAL | ||
| Float_t PCAL; | ||
| ///Sampling fraction on the ECIN | ||
| Float_t ECIN; | ||
| ///Sampling fraction on the ECOUT | ||
| Float_t ECOUT; | ||
| ///Second-momenta of PCAL | ||
| Float_t m2PCAL; | ||
| ///Second-momenta of ECIN | ||
| Float_t m2ECIN; | ||
| ///Second-momenta of ECOUT | ||
| Float_t m2ECOUT; | ||
|
|
||
| /// @brief Add variables to the readerTMVA | ||
| readerTMVA->AddVariable( "P",&P ); | ||
| readerTMVA->AddVariable( "Theta",&Theta); | ||
| readerTMVA->AddVariable( "Phi",&Phi); | ||
| readerTMVA->AddVariable( "SFPCAL",&PCAL); | ||
| readerTMVA->AddVariable( "SFECIN",&ECIN); | ||
| readerTMVA->AddVariable( "SFECOUT",&ECOUT ); | ||
| readerTMVA->AddVariable( "m2PCAL",&m2PCAL); | ||
| readerTMVA->AddVariable( "m2ECIN",&m2ECIN); | ||
| readerTMVA->AddVariable( "m2ECOUT",&m2ECOUT); | ||
|
|
||
| readerTMVA->BookMVA( "BDT", o_weightfile_fullpath ); |
There was a problem hiding this comment.
The header should only declare the variables, not define them; the definitions could go in the Start() method in Algorithm.cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.