-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade everything #471
base: main
Are you sure you want to change the base?
Upgrade everything #471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Jefiozie - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider breaking this upgrade into multiple smaller PRs, upgrading one major version at a time (e.g. Angular 14->15->16->17->18->19) to reduce risk and make issues easier to debug if they occur.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
if (fs.existsSync(nxPath + ext)) | ||
fs.writeFileSync(ngPath + ext, fs.readFileSync(nxPath + ext)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code-quality): Use block braces for ifs, whiles, etc. (use-braces
)
if (fs.existsSync(nxPath + ext)) | |
fs.writeFileSync(ngPath + ext, fs.readFileSync(nxPath + ext)); | |
if (fs.existsSync(nxPath + ext)) { | |
fs.writeFileSync(ngPath + ext, fs.readFileSync(nxPath + ext)); | |
} | |
Explanation
It is recommended to always use braces and create explicit statement blocks.Using the allowed syntax to just write a single statement can lead to very confusing
situations, especially where subsequently a developer might add another statement
while forgetting to add the braces (meaning that this wouldn't be included in the condition).
4006936
to
15b5bc4
Compare
15b5bc4
to
cbc09ee
Compare
Summary by Sourcery
Update Angular to version 19, Nx to version 20, and other dependencies to their latest versions. Remove postinstall script and ngcc from package.json. Migrate from nrwl to nx.
Build:
Tests: