Refactoring and Multiprocessing #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cox's package relies on relative paths to run. It assumes the main Python process is running in its root dir. This wrapper runs the necessary methods within the root of the submodule and then moves the working dir back to the original one. It returns a configured instance of the Migdal class from the submodule for which the probabilities and total probabilities have already been computed.
Refactored the code so that the Migdal model can be selected using a simple keyword argument. Examples will be prepared in the notebooks/ dir. Two tests have been added: - One for Cox's full model for single ionization rates - One for Cox's model using dipole approximation
This reverts commit 8bde989.
This reverts commit e0d51d4.
Without it, pytests do not recognise wimprates.data.migdal.Cox modules
Bump action versions. Use `pip install -e .` instead of `python setup.py develop` as the latter is now deprecated. Trying to fix issue with jinja2 being deprecated.
The following error arises while `Test package` executes in the workflow. The following suggestion was followed: d2l-ai/d2l-book#46 (comment)
Recursively checkout submodules
Refactored a bit the code here to remove expensive and unutilised computation on import of wimprates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependant on the approval and merging of PR #17
The optimisation branch includes several performance improvements and optimizations to enhance the efficiency and speed of the codebase.
wimprates/electron.pyhas been removed to reduce significant overhead.functools.lru_cachemethod was applied to a few functionswrimprates.rate_wimpif arguments and wimprates' version are the same.