Merge pull request #54 from Jena-Earth-Observation-School/fix_override

Fix: Override common load parameters
Jena-Earth-Observation-School · May 2, 2024 · fe80ad4 · fe80ad4
2 parents f513174 + 381db98
commit fe80ad4
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/sdc/products/_ancillary.py b/sdc/products/_ancillary.py
@@ -75,10 +75,12 @@ def override_common_params(params: dict[str, Any],
     from odc.stac import load as odc_stac_load
     allowed = inspect.getfullargspec(odc_stac_load).kwonlyargs
 
-    for key in kwargs:
+    for key, val in kwargs.items():
         if key not in allowed:
             raise ValueError(f"Parameter '{key}' is not allowed.")
-    params.update(kwargs)
+        if val is not None:
+            params[key] = val
+
     if verbose:
         print(f"[INFO] odc.stac.load parameters: {params}")
     return params