Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
JerAguilon committed Feb 16, 2024
1 parent b449ef5 commit 628dd0a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion cpp/src/arrow/acero/asof_join_node_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
// under the License.

#include <gmock/gmock-matchers.h>
#include <iostream> // nocommit

#include <chrono>
#include <memory>
Expand Down Expand Up @@ -1585,6 +1584,10 @@ TEST(AsofJoinTest, BatchSequencing) {

template <typename BatchesMaker>
void TestSchemaResolution(BatchesMaker maker, int num_batches, int batch_size) {
// GH-39803: The key hasher needs to resolve the types of key columns. All other
// tests use int32 for all columns, but this test converts the key columns to
// strngs via a projection node to test that the column is correctly resolved
// to string.
auto l_schema =
schema({field("time", int32()), field("key", int32()), field("l_value", int32())});
auto r_schema =
Expand Down

0 comments on commit 628dd0a

Please sign in to comment.