forked from apache/arrow
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
apacheGH-37941: [R][CI][Release] Add checksum verification for pre-co…
…mpiled binaries (apache#38115) ### Rationale for this change This change is to restore parity with the previous solution on macOS (brew does cs validation) and improve security for windows and linux. This also align with CRAN policy. ### What changes are included in this PR? This PR adds a script that can be run after the arrow release (once all files have been pushed to the artifactory) before the CRAN submission to download the checksum files for the pre-compiled binaries which are already added through the usual release. *libs.R have been extended to use these checksum files to validate the downloaded binaries. ### Are these changes tested? The r-binary-packages nightlies generate checksums and use them when building binary packages, this way the code path is tested. They do not modify the actual src package though. ### Are there any user-facing changes? no (outside of log messages) * Closes: apache#37941 Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Nic Crane <[email protected]>
- Loading branch information
1 parent
6281110
commit ba7b240
Showing
7 changed files
with
213 additions
and
57 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| # Run this script AFTER the release was voted and the artifacts | ||
| # are moved into the final dir. This script will download the checksum | ||
| # files and save them to the tools/checksums directory mirroring the | ||
| # artifactory layout. *libs.R uses these files to validated the downloaded | ||
| # binaries when installing the package. | ||
| # | ||
| # Run this script from the r/ directory of the arrow repo with the version | ||
| # as the first argument$ Rscript tools/update-checksum.R 14.0.0 | ||
|
|
||
| args <- commandArgs(TRUE) | ||
| VERSION <- args[1] | ||
| tools_root <- "" | ||
|
|
||
| if (length(args) != 1) { | ||
| stop("Usage: Rscript tools/update-checksums.R <version>") | ||
| } | ||
|
|
||
| tasks_yml <- "../dev/tasks/tasks.yml" | ||
|
|
||
| if (!file.exists(tasks_yml)) { | ||
| stop("Run this script from the r/ directory of the arrow repo") | ||
| } | ||
|
|
||
| # Get the libarrow binary paths from the tasks.yml file | ||
| binary_paths <- readLines(tasks_yml) |> | ||
| grep("r-lib__libarrow", x = _, value = TRUE) |> | ||
| sub(".+r-lib__libarrow__bin__(.+\\.zip)", "\\1", x = _) |> | ||
| sub("{no_rc_r_version}", VERSION, fixed = TRUE, x = _) |> | ||
| sub("__", "/", x = _) |> | ||
| sub("\\.zip", ".zip", fixed = TRUE, x = _) | ||
|
|
||
| artifactory_root <- "https://apache.jfrog.io/artifactory/arrow/r/%s/libarrow/bin/%s" | ||
|
|
||
| # Get the checksuym file from the artifactory | ||
| for (path in binary_paths) { | ||
| sha_path <- paste0(path, ".sha512") | ||
| file <- file.path("tools/checksums", sha_path) | ||
| dirname(file) |> dir.create(path = _, recursive = TRUE, showWarnings = FALSE) | ||
|
|
||
| url <- sprintf(artifactory_root, VERSION, sha_path) | ||
| download.file(url, file, quiet = TRUE, cacheOK = FALSE) | ||
|
|
||
| if (grepl("windows", path)) { | ||
| # UNIX style line endings cause errors with mysys2 sha512sum | ||
| sed_status <- system2("sed", args = c("-i", "s/\\r//", file)) | ||
| if (sed_status != 0) { | ||
| stop("Failed to remove \\r from windows checksum file. Exit code: ", sed_status) | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters