Added webpack with support for ES6, updated packages and more #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rly all packages and moved and renamed a few assets
|
This is pretty awesome! Unfortunately, I think this is too large of a change to push into the current version. However, I'd love to discuss this for JointsWP 6: #366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I've integrated webpack with babel for scripts compiling instead of compiling with only gulp-babel, mainly to fix the ResponsiveAccordeonTabs plugin, which was not working correctly. This is also more future-proof, if you want to integrate frameworks like Vue or React and use their templating systems (like I've done for a project). I've also updated packages and replaced a slew of gulp-{plugin} for their original counterpart in order to get better update support. I've added a Prettier config file for formatting consistency. The translation folder has been moved to assets and the script files have been overhauled to support ES6 syntax (and this is where you need to comment out Foundation plugins you don't use now). The gulpfile has seen many changes to incorporate the above and lastly I've added support for production/development environments in the scripts you run to make changes in this theme.