-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved compile time performance (clang/gcc) #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and `order_by` to seperate include file, and removing `<functional>` need
a9c15de
to
2a3c639
Compare
1840d6b
to
3ebef98
Compare
6fa4161
to
e69cc21
Compare
e69cc21
to
bfa9af1
Compare
Comment on lines
+64
to
+66
{ | ||
return thread_name(std::this_thread::get_id()); | ||
} |
Check failure
Code scanning / CodeQL
Missing return statement
Function thread_name should return a value of type const string8_t but does not return a value here
Comment on lines
+57
to
+59
{ | ||
return m_ThreadMap[id]; | ||
} |
Check failure
Code scanning / CodeQL
Missing return statement
Function thread_name should return a value of type const string8_t but does not return a value here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note the following body of work mostly affects clang and gcc. msvc will come in another PR. The performance of msvc did not noticeably change during the course of this PR.
Compile time performance was improved for clang/gcc by doing the following:
<fstream>
inustring.hpp
by moving it toustream.hpp
psl::ecs::state_t::on_condition
to its own filepsl/ecs/on_condition.hpp
, this removed the need forpsl/ecs/details/execution.hpp
which includes<execution>
psl::ecs::state_t::order_by
to its own filepsl/ecs/order_by.hpp
, this resulted in<future>
no longer being needed instate.hpp
ustring.hpp
forassertions.hpp
, and<fmt>
in case of non-debug buildsassertions.hpp
from automatic inclusion everywhereutility::debug
to a seperate filedebug_utils.hpp/cpp
psl::serializer
to lower compilation pressure. Future work should be done in respect of Polymorphic serialization is linked to specific encoder/decoder #70platform_utils.hpp
, mostly by moving code toplatform_utils.cpp
Locally this resulted in a drop of 15%-20% seconds across all TU's (measured using clang12 w/
-ftime-trace
)