-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring before the release #321
Merged
arksap2002
merged 37 commits into
ebraun/bugs/psi-related-bugs/top-level-function
from
arksap2002/refactoring/remove-services
Aug 28, 2024
Merged
Refactoring before the release #321
arksap2002
merged 37 commits into
ebraun/bugs/psi-related-bugs/top-level-function
from
arksap2002/refactoring/remove-services
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arksap2002
changed the title
Remove services and helpers
Refactoring before the release
Aug 22, 2024
arksap2002
added
bug
Something isn't working
Ready for review
PR redy for review
labels
Aug 22, 2024
pderakhshanfar
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a set of minor comments. I will approve the PR when they are addressed. Thanks :)
...n/kotlin/org/jetbrains/research/testspark/display/generatedTests/GeneratedTestsTabBuilder.kt
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/research/testspark/display/generatedTests/TestCasePanelBuilder.kt
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/research/testspark/display/utils/template/DisplayUtils.kt
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/research/testspark/helpers/LLMHelper.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/research/testspark/tools/factories/TestCompilerFactory.kt
Show resolved
Hide resolved
…rksap2002/refactoring/remove-services
…/improvments/fix-plugin-logo
pderakhshanfar
approved these changes
Aug 28, 2024
…s/fix-plugin-logo Fix plugin logo issue
arksap2002
merged commit Aug 28, 2024
945c7a8
into
ebraun/bugs/psi-related-bugs/top-level-function
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes made
Huge refactoring before a new release. The main points to fix are:
For reviewers
This implementation is similar to #196, but with the kotlin implementation. I tried to fix merge conflicts, but I found easier to implement it again, because of the big project structure changings.
This PR contains a lot of modified lined, the main reason is the files paths changings. I separated my implementation in logical commits, I think it's better to go throught them one by one.
New display structure
Closed issues
#208
#322