-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix-ups for "significant proof checking refactoring" #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by recent refactoring
Pass abort signal into coq-lsp client correctly in benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the last refactoring PR was closed too quickly and without proper review, resulting in several vulnerabilities in the code.
The goal of this PR is to fix the key issues and improve code style where possible.
👮 Fix-ups
Theorem.proof
nullabilityProofGoal
alias again instead ofGoal<PpString>
CoqLspClient.getFirstGoalAtPointOrThrow(...)
properly: this method should be the only call needed, rather than chained after thegetGoalsAtPoint
imm
submodule commit: it should point at the existing commit (as it was made in main), otherwise it won't work in TeamCityCoqLspClient
invariantsSessionState.restartSession()
bug (not all the fields were updated) and remove aborting from itsdispose()
methodtoString()
call) causing the proof-checker to failcore
directory: since core functions use these utils, they shouldn't stay in theextension
folderCoqLspClient.dispose()
be awaited?CoqLspClient
-s starts separate processes that have nothing shared; therefore, it is okay to dispose the old one later asynchronously without waiting for it explicitly.SessionState
object instead of restarting the same one; is it possible?SessionState
has theactiveSession
boolean trigger, it could not be destructed completely, therefore it is recreated.👍 General improvements
SessionState
parsedTypes.ts
classesCoqLspClient.withTextDocument(...)
wrapper to encapsulate opening and closing a document with coq-lspCoqLspClient
disposalCoqProofChecker.checkProofs(...)
arguments & get rid of unusedCoqProofCheckerInterface
extension
directory: it became pretty hard to use because of a huge number of files inside