Introduce orphanPointerMoveEvents test #2192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Jun 23, 2025
|
|
||
| // this sequence of events triggers click since heterogenous "move" events does not affect release | ||
| // this never suppose to happen but actually happens | ||
| // see https://youtrack.jetbrains.com/issue/CMP-8430/Sequence-of-Move-PointerInputEvents-cancel-out-press-PointerInputEvent-under-certain-conditions |
There was a problem hiding this comment.
I'd create a fix without postponing instead of adding the test for current behaviour.
It should be simple - we already have such logic for pointers inside SyntheticEventSender, so you just need to add buttons field check there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sole purpose of this PR is to introduce separate test that documents current behaviour of pointer event system whenever some inconsistent set of move events is passed.
This behaviour should be fixed and the test will be corrected alongside with that fix.
See https://youtrack.jetbrains.com/issue/CMP-8430/Sequence-of-Move-PointerInputEvents-cancel-out-press-PointerInputEvent-under-certain-conditions
Testing
./gradlew testWeb testDesktopRelease Notes
N/A