suggest with container provider #930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
requested changes
Dec 8, 2023
|
|
||
| @OptIn(InternalComposeApi::class) | ||
| @Composable | ||
| internal fun ProvideContainerCompositionLocals( |
There was a problem hiding this comment.
I think it was better - as I said before, it doesn't seem right at all to have @Composable functions inside UIViewController
Also, you're exposing interfaceOrientationState and systemThemeState via locals anyway
dima-avdeev-jb
force-pushed
the
dima.avdeev/ios-single-layer-compose-scene
branch
from
24334fd to
76cfbe7
Compare
Base automatically changed from
dima.avdeev/ios-single-layer-compose-scene
to
jb-main
December 9, 2023 06:45
dima-avdeev-jb
deleted the
dima.avdeev/suggest-with-container-provider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think, better move extension function ProvideContainerCompositionLocals to class member.
Then we can change to private visibility for values interfaceOrientationState and systemThemeState