This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
release v1.0 #1
Open
release v1.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 25, 2019 11:24
dtretyakov
reviewed
Aug 1, 2019
| val path = Path.of("./project.assets.json") | ||
| val streamFactory = ProjectStreamFactoryStub() | ||
| .add(path, this::class.java.getResourceAsStream(target)) | ||
| .add(Path.of("/Users/mikhail.nikolyukin/.config/NuGet/NuGet.Config"), this::class.java.getResourceAsStream(config)) |
There was a problem hiding this comment.
Local file path, we need to change it on something user-neutral
There was a problem hiding this comment.
Users/mikhail.nikolyukin/.config/NuGet/NuGet.Config is global config.
I can change path to something like ../../../../.config/NuGet/NuGet.Config using relativeTo(projectDir), but isn't absolute path better?
There was a problem hiding this comment.
Is /Users/mikhail.nikolyukin/.config/NuGet/NuGet.Config a fake path? If so could we use "/Users/username/.config/NuGet/NuGet.Config" instead?
…SBuildSolutionDeserializer
… remove solution print to log because it makes a lot of noise
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.